Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes #97

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Logging fixes #97

merged 2 commits into from
Mar 21, 2024

Conversation

orbitalturtle
Copy link
Collaborator

Whoops @carlaKC, the original PR, I had it pointing toward #91 instead of master, so we merged it to the wrong place. My bad!

This PR is the same but just one other small change: Now uses println! instead of error! to print the log setup error. If we use error!, this doesn't show up for the user because the logger isn't set up yet.

@orbitalturtle orbitalturtle requested a review from carlaKC March 19, 2024 20:59
@carlaKC carlaKC merged commit fa73fd6 into master Mar 21, 2024
3 checks passed
@orbitalturtle orbitalturtle deleted the log-tweaks-2 branch May 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants