Remove BENCH_TEST macro #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustofg
requested changes
May 18, 2023
|
Also, just pointing out that saying that the 'IPMB pins are unconnected' can be a bit misleading, since what we are checking is the GAx pins (global address pins) to see if the AMC card is plugged or not to the MicroTCA crate. The IPMB refers to the I2C bus used to transfer IPMI traffic between the AMC and the MCH, but in some cases we might simulate an MCH on the bench and connect the IPMB bus, even though the AMC would be running in the 'standalone' mode. |
gustavosr8
force-pushed
the
remove-test-bench-macro
branch
from
2846e67 to
123b877
Compare
gustavosr8
force-pushed
the
remove-test-bench-macro
branch
from
123b877 to
6d15298
Compare
augustofg
requested changes
May 19, 2023
gustavosr8
force-pushed
the
remove-test-bench-macro
branch
2 times, most recently
from
8511b8d to
735317f
Compare
augustofg
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the BENCH_TEST macro by checking if the IPMB pins are unconnected and setting the standalone mode. Resolve #133.