Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong read of FRU content #152

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix the wrong read of FRU content #152

merged 1 commit into from
Jul 10, 2023

Conversation

gustavosr8
Copy link
Contributor

When trying to read the FRU contents via ipmitool, it return different/incomplete data every time. This occurs due to a fail when trying to take the mutex for read the memory. Increazing the timeout value solve the problem.

@gustavosr8 gustavosr8 linked an issue Jul 7, 2023 that may be closed by this pull request
@gustavosr8 gustavosr8 requested a review from augustofg July 7, 2023 17:01
@gustavosr8 gustavosr8 self-assigned this Jul 7, 2023
Copy link
Member

@augustofg augustofg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit summary to "Fix IPMI FRU Read command returning invalid data"

modules/fru.c Outdated Show resolved Hide resolved
@gustavosr8 gustavosr8 force-pushed the fru-read-workaround branch 3 times, most recently from e6b8fcf to b2c2ca3 Compare July 10, 2023 13:12
modules/fru.c Outdated Show resolved Hide resolved
modules/fru.c Show resolved Hide resolved
When trying to read the FRU contents via ipmitool, it return
different/incomplete data every time. This occurs due to a fail when
trying to take the mutex for read the memory. Increazing the timeout
value solve the problem.
@gustavosr8 gustavosr8 force-pushed the fru-read-workaround branch from b2c2ca3 to 4dfcd82 Compare July 10, 2023 13:29
@augustofg
Copy link
Member

👍

@augustofg augustofg merged commit acf2500 into devel Jul 10, 2023
@augustofg augustofg deleted the fru-read-workaround branch July 10, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPMI fru read command not reliable
2 participants