Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change delay counts from ticks to ms #199

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Change delay counts from ticks to ms #199

merged 1 commit into from
Feb 23, 2024

Conversation

gustavosr8
Copy link
Contributor

No description provided.

@gustavosr8 gustavosr8 linked an issue Jan 30, 2024 that may be closed by this pull request
Change all functions that pass FreeRTOS's Ticks as arguments to milisseconds #68
Closed
augustofg
augustofg requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@augustofg augustofg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other places that you should also use the pdMS_TO_TICKS() macro, like when acquiring mutexes, reading / writing to queues, and waiting for events.

modules/rtm.c Outdated Show resolved Hide resolved
modules/sensors/lm75.c Outdated Show resolved Hide resolved
modules/sensors/max6642.c Outdated Show resolved Hide resolved
modules/watchdog.c Show resolved Hide resolved
modules/eeprom_24xx64.c Outdated Show resolved Hide resolved
@gustavosr8 gustavosr8 force-pushed the delay-ms branch 4 times, most recently from 962b07a to b242cce Compare February 23, 2024 15:41
@augustofg
Copy link
Member

👍

@augustofg augustofg merged commit 944e621 into devel Feb 23, 2024
6 checks passed
@augustofg augustofg deleted the delay-ms branch February 23, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustofg augustofg augustofg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change all functions that pass FreeRTOS's Ticks as arguments to milisseconds
2 participants
@gustavosr8 @augustofg