Dummy handler to receive the I2CSlaveAddr when don't match the IPMBAddr #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I propose the following commit message: |
When repeatedly upgrading and downgrading the openMMC via ipmitool, it crashes sporadically at Chip_I2C_SlaveStateHandler. This happens because for some motive, when calling startMasterXfer() sometimes an interrupt occurs for the I2C0 peripheral, and the Chip_I2C_SlaveStateHandler is called, dispatching the handling to the callback registered for I2C_SLAVE_GENERAL. But, this callback is not configured, resulting in a invalid memory access. It is not clear why this interrupt is generated for an I2C slave address other than the expected IPMB address obtained by get_ipmb_addr(), but this should be properly handled and not lead to a crash. Fixes #160.
gustavosr8
force-pushed
the
i2c-slave-handle-bug
branch
from
ab9cbb1 to
80a81f5
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When repeatedly upgrading and downgrading the openMMC via ipmitool, it crashes because the si2c->xfer pointer in Chip_I2C_SlaveStateHandler was uninitialized (NULL), what happens because the received I2C Slave Address doesn't match the expected IPMB address. Solve #160.