Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Advanced Details windows to RF Controls #704

Merged
merged 75 commits into from
Sep 6, 2024
Merged

Conversation

JAFeltran
Copy link
Contributor

@JAFeltran JAFeltran commented Sep 5, 2024

Adds the Advanced Details tab to Start Controls, containing buttons which open different details windows.

  • Main Window:

Captura de tela de 2024-09-05 08-44-30

  • ADCs and DACs:

Captura de tela de 2024-09-05 08-46-07

Captura de tela de 2024-09-05 08-46-13

  • Hardware:

Captura de tela de 2024-09-05 08-46-21

  • Loops:

Captura de tela de 2024-09-05 08-46-28

Captura de tela de 2024-09-05 08-46-40

Captura de tela de 2024-09-05 08-46-34

  • Equations:

Captura de tela de 2024-09-05 08-46-46

  • Loop Limits:

Captura de tela de 2024-09-05 08-46-53

  • Cavity Ramps:

Captura de tela de 2024-09-05 08-47-03

Captura de tela de 2024-09-05 08-47-09

  • Ramp Limits:

Captura de tela de 2024-09-05 08-47-14

  • Auto Start:

Captura de tela de 2024-09-05 08-47-22

  • Conditioning:
    Captura de tela de 2024-09-05 10-05-26

  • Tuning:

Captura de tela de 2024-09-05 08-47-34

Captura de tela de 2024-09-05 08-47-40

  • Calibration:

Captura de tela de 2024-09-05 08-47-49

Captura de tela de 2024-09-05 08-47-54

  • Advanced Interlock (accessed through the interlock detail window):

Captura de tela de 2024-09-05 08-54-24

Captura de tela de 2024-09-05 08-54-29

Additionaly, adds a FDL tab to LLRF, including amplitude graphs:

Captura de tela de 2024-09-05 08-45-43

Copy link
Contributor

@fernandohds564 fernandohds564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work!
So impressive that's impossible to review all the 6000+ lines 😄

@JAFeltran
Copy link
Contributor Author

Impressive work! So impressive that's impossible to review all the 6000+ lines 😄

Thank you!

@anacso17 anacso17 merged commit 11f8e64 into master Sep 6, 2024
1 check passed
@anacso17 anacso17 deleted the add_advanced_details branch September 6, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants