LNX-169: Add custom sort collector #213
ChillFish8Annotations
86 warnings
|
fmt
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
deref which would be done by auto-deref:
lnx-fs/src/metastore/mod.rs#L125
warning: deref which would be done by auto-deref
--> lnx-fs/src/metastore/mod.rs:125:34
|
125 | .filter(|entry| pred(&*entry))
| ^^^^^^^ help: try: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
lnx-fs/src/metastore/mod.rs#L125
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lnx-fs/src/metastore/mod.rs:125:34
|
125 | .filter(|entry| pred(&*entry))
| ^^^^^^^ help: change this to: `*entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
deref on an immutable reference:
lnx-fs/src/metastore/mod.rs#L125
warning: deref on an immutable reference
--> lnx-fs/src/metastore/mod.rs:125:34
|
125 | .filter(|entry| pred(&*entry))
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
help: if you would like to reborrow, try removing `&*`
|
125 | .filter(|entry| pred(entry))
| ~~~~~
help: if you would like to deref, try using `&**`
|
125 | .filter(|entry| pred(&**entry))
| ~~~~~~~~
|
|
the following explicit lifetimes could be elided: 'a:
lnx-fs/src/metastore/mutate.rs#L14
warning: the following explicit lifetimes could be elided: 'a
--> lnx-fs/src/metastore/mutate.rs:14:6
|
14 | impl<'a> BulkMetastoreModifyOperation<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
14 - impl<'a> BulkMetastoreModifyOperation<'a> {
14 + impl BulkMetastoreModifyOperation<'_> {
|
|
|
associated function `new` is never used:
lnx-tantivy/src/collectors/top_docs/mod.rs#L197
warning: associated function `new` is never used
--> lnx-tantivy/src/collectors/top_docs/mod.rs:197:8
|
196 | impl<T: PartialOrd + Clone> TopSegmentCollector<T> {
| -------------------------------------------------- associated function in this implementation
197 | fn new(segment_ord: SegmentOrdinal, limit: usize) -> TopSegmentCollector<T> {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused variable: `score`:
lnx-tantivy/src/collectors/top_docs/mod.rs#L462
warning: unused variable: `score`
--> lnx-tantivy/src/collectors/top_docs/mod.rs:462:14
|
462 | for (score, doc) in expected_docs {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_score`
|
= note: `#[warn(unused_variables)]` on by default
|
|
useless conversion to the same type: `std::string::String`:
lnx-doc/src/borrowed_value.rs#L221
warning: useless conversion to the same type: `std::string::String`
--> lnx-doc/src/borrowed_value.rs:221:42
|
221 | Ok(BorrowedValue::Str(Cow::Owned(v.into())))
| ^^^^^^^^ help: consider removing `.into()`: `v`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
field `0` is never read:
lnx-doc/src/borrowed_value.rs#L334
warning: field `0` is never read
--> lnx-doc/src/borrowed_value.rs:334:28
|
334 | struct CowBytesWrapper<'a>(Cow<'a, [u8]>);
| --------------- ^^^^^^^^^^^^^
| |
| field in this struct
|
= help: consider removing this field
= note: `#[warn(dead_code)]` on by default
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L1106
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:1106:9
|
1106 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L1066
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:1066:9
|
1066 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L1027
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:1027:9
|
1027 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L986
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:986:9
|
986 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L949
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:949:9
|
949 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
unused import: `debug`:
lnx-tantivy/src/directory/vfs.rs#L21
warning: unused import: `debug`
--> lnx-tantivy/src/directory/vfs.rs:21:15
|
21 | use tracing::{debug, warn};
| ^^^^^
|
|
unused import: `crate::collectors::TopDocs`:
lnx-tantivy/src/collectors/top_docs/custom_sort.rs#L320
warning: unused import: `crate::collectors::TopDocs`
--> lnx-tantivy/src/collectors/top_docs/custom_sort.rs:320:9
|
320 | use crate::collectors::TopDocs;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
unused import: `QueryParser`:
lnx-tantivy/src/collectors/top_docs/custom_sort.rs#L315
warning: unused import: `QueryParser`
--> lnx-tantivy/src/collectors/top_docs/custom_sort.rs:315:36
|
315 | use tantivy::query::{AllQuery, QueryParser};
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L822
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:822:9
|
822 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
unused import: `tantivy::indexer::NoMergePolicy`:
lnx-tantivy/tests/test_indexing_merges.rs#L4
warning: unused import: `tantivy::indexer::NoMergePolicy`
--> lnx-tantivy/tests/test_indexing_merges.rs:4:5
|
4 | use tantivy::indexer::NoMergePolicy;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L362
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:362:9
|
362 | mut self,
| ^^^^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L333
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:333:9
|
333 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L296
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:296:9
|
296 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L249
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:249:9
|
249 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L209
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:209:9
|
209 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
method `to_collector_predicate` is never used:
lnx-models/src/query.rs#L1149
warning: method `to_collector_predicate` is never used
--> lnx-models/src/query.rs:1149:8
|
1148 | impl OneOrManySortBy {
| -------------------- method in this implementation
1149 | fn to_collector_predicate(&self) {}
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L1105
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:1105:8
|
1104 | impl GteExpr {
| ------------ method in this implementation
1105 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L1065
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:1065:8
|
1064 | impl GtExpr {
| ----------- method in this implementation
1065 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L1026
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:1026:8
|
1025 | impl LteExpr {
| ------------ method in this implementation
1026 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L985
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:985:8
|
984 | impl LtExpr {
| ----------- method in this implementation
985 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L948
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:948:8
|
947 | impl NeqExpr {
| ------------ method in this implementation
948 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
methods `ensure_valid` and `make_query` are never used:
lnx-models/src/query.rs#L870
warning: methods `ensure_valid` and `make_query` are never used
--> lnx-models/src/query.rs:870:8
|
869 | impl RangeBounds {
| ---------------- methods in this implementation
870 | fn ensure_valid(&self) -> Result<(), QueryBuildError> {
| ^^^^^^^^^^^^
...
882 | fn make_query(&self, field: Field) -> RangeQuery {
| ^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L821
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:821:8
|
820 | impl RangeExpr {
| -------------- method in this implementation
821 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L361
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:361:8
|
360 | impl ExistsExpr {
| --------------- method in this implementation
361 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L332
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:332:8
|
331 | impl NotExpr {
| ------------ method in this implementation
332 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L295
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:295:8
|
294 | impl AtLeastExpr {
| ---------------- method in this implementation
295 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L248
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:248:8
|
247 | impl AnyExpr {
| ------------ method in this implementation
248 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L208
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:208:8
|
207 | impl AllExpr {
| ------------ method in this implementation
208 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L155
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:155:8
|
154 | impl WhereClause {
| ---------------- method in this implementation
155 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `BucketConfig`:
lnx-fs/lnx-fs-benches/src/main.rs#L13
warning: unused import: `BucketConfig`
--> lnx-fs/lnx-fs-benches/src/main.rs:13:20
|
13 | use lnx_fs::{Body, BucketConfig, Bytes, RuntimeOptions, VirtualFileSystem};
| ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
all variants have the same postfix: `Endpoints`:
lnx-server/src/apis/mod.rs#L12
warning: all variants have the same postfix: `Endpoints`
--> lnx-server/src/apis/mod.rs:12:1
|
12 | / pub(super) enum Tag {
13 | | #[oai(rename = "Health Endpoints")]
14 | | /// Service health related endpoints
15 | | ///
... |
40 | | QueryEndpoints,
41 | | }
| |_^
|
= help: remove the postfixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
|
|
all variants have the same postfix: `Endpoints`:
lnx-server/src/apis/mod.rs#L12
warning: all variants have the same postfix: `Endpoints`
--> lnx-server/src/apis/mod.rs:12:1
|
12 | / pub(super) enum Tag {
13 | | #[oai(rename = "Health Endpoints")]
14 | | /// Service health related endpoints
15 | | ///
... |
40 | | QueryEndpoints,
41 | | }
| |_^
|
= help: remove the postfixes and use full paths to the variants instead of glob imports
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
= note: `#[warn(clippy::enum_variant_names)]` on by default
|
|
unused variable: `data_path`:
lnx-server/src/lib.rs#L16
warning: unused variable: `data_path`
--> lnx-server/src/lib.rs:16:46
|
16 | pub async fn run(listen_address: SocketAddr, data_path: PathBuf) -> Result<()> {
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_data_path`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unused import: `Object`:
lnx-server/src/apis/query.rs#L3
warning: unused import: `Object`
--> lnx-server/src/apis/query.rs:3:20
|
3 | use poem_openapi::{Object, OpenApi};
| ^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused variable: `data_path`:
lnx-server/src/lib.rs#L16
warning: unused variable: `data_path`
--> lnx-server/src/lib.rs:16:46
|
16 | pub async fn run(listen_address: SocketAddr, data_path: PathBuf) -> Result<()> {
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_data_path`
|
= note: `#[warn(unused_variables)]` on by default
|
|
unused import: `Object`:
lnx-server/src/apis/query.rs#L3
warning: unused import: `Object`
--> lnx-server/src/apis/query.rs:3:20
|
3 | use poem_openapi::{Object, OpenApi};
| ^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L1106
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:1106:9
|
1106 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L1066
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:1066:9
|
1066 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L1027
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:1027:9
|
1027 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L986
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:986:9
|
986 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L949
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:949:9
|
949 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L822
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:822:9
|
822 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
unused import: `BucketConfig`:
lnx-fs/lnx-fs-benches/src/main.rs#L13
warning: unused import: `BucketConfig`
--> lnx-fs/lnx-fs-benches/src/main.rs:13:20
|
13 | use lnx_fs::{Body, BucketConfig, Bytes, RuntimeOptions, VirtualFileSystem};
| ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L362
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:362:9
|
362 | mut self,
| ^^^^^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L333
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:333:9
|
333 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L296
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:296:9
|
296 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L249
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:249:9
|
249 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference:
lnx-models/src/query.rs#L209
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
--> lnx-models/src/query.rs:209:9
|
209 | self,
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
method `to_collector_predicate` is never used:
lnx-models/src/query.rs#L1149
warning: method `to_collector_predicate` is never used
--> lnx-models/src/query.rs:1149:8
|
1148 | impl OneOrManySortBy {
| -------------------- method in this implementation
1149 | fn to_collector_predicate(&self) {}
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L1105
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:1105:8
|
1104 | impl GteExpr {
| ------------ method in this implementation
1105 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L1065
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:1065:8
|
1064 | impl GtExpr {
| ----------- method in this implementation
1065 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L1026
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:1026:8
|
1025 | impl LteExpr {
| ------------ method in this implementation
1026 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L985
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:985:8
|
984 | impl LtExpr {
| ----------- method in this implementation
985 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L948
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:948:8
|
947 | impl NeqExpr {
| ------------ method in this implementation
948 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
methods `ensure_valid` and `make_query` are never used:
lnx-models/src/query.rs#L870
warning: methods `ensure_valid` and `make_query` are never used
--> lnx-models/src/query.rs:870:8
|
869 | impl RangeBounds {
| ---------------- methods in this implementation
870 | fn ensure_valid(&self) -> Result<(), QueryBuildError> {
| ^^^^^^^^^^^^
...
882 | fn make_query(&self, field: Field) -> RangeQuery {
| ^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L821
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:821:8
|
820 | impl RangeExpr {
| -------------- method in this implementation
821 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L361
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:361:8
|
360 | impl ExistsExpr {
| --------------- method in this implementation
361 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L332
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:332:8
|
331 | impl NotExpr {
| ------------ method in this implementation
332 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L295
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:295:8
|
294 | impl AtLeastExpr {
| ---------------- method in this implementation
295 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L248
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:248:8
|
247 | impl AnyExpr {
| ------------ method in this implementation
248 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L208
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:208:8
|
207 | impl AllExpr {
| ------------ method in this implementation
208 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
|
method `to_tantivy_query` is never used:
lnx-models/src/query.rs#L155
warning: method `to_tantivy_query` is never used
--> lnx-models/src/query.rs:155:8
|
154 | impl WhereClause {
| ---------------- method in this implementation
155 | fn to_tantivy_query(
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
associated function `new` is never used:
lnx-tantivy/src/collectors/top_docs/mod.rs#L197
warning: associated function `new` is never used
--> lnx-tantivy/src/collectors/top_docs/mod.rs:197:8
|
196 | impl<T: PartialOrd + Clone> TopSegmentCollector<T> {
| -------------------------------------------------- associated function in this implementation
197 | fn new(segment_ord: SegmentOrdinal, limit: usize) -> TopSegmentCollector<T> {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `debug`:
lnx-tantivy/src/directory/vfs.rs#L21
warning: unused import: `debug`
--> lnx-tantivy/src/directory/vfs.rs:21:15
|
21 | use tracing::{debug, warn};
| ^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
deref which would be done by auto-deref:
lnx-fs/src/metastore/mod.rs#L125
warning: deref which would be done by auto-deref
--> lnx-fs/src/metastore/mod.rs:125:34
|
125 | .filter(|entry| pred(&*entry))
| ^^^^^^^ help: try: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
lnx-fs/src/metastore/mod.rs#L125
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lnx-fs/src/metastore/mod.rs:125:34
|
125 | .filter(|entry| pred(&*entry))
| ^^^^^^^ help: change this to: `*entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
deref on an immutable reference:
lnx-fs/src/metastore/mod.rs#L125
warning: deref on an immutable reference
--> lnx-fs/src/metastore/mod.rs:125:34
|
125 | .filter(|entry| pred(&*entry))
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
help: if you would like to reborrow, try removing `&*`
|
125 | .filter(|entry| pred(entry))
| ~~~~~
help: if you would like to deref, try using `&**`
|
125 | .filter(|entry| pred(&**entry))
| ~~~~~~~~
|
|
the following explicit lifetimes could be elided: 'a:
lnx-fs/src/metastore/mutate.rs#L14
warning: the following explicit lifetimes could be elided: 'a
--> lnx-fs/src/metastore/mutate.rs:14:6
|
14 | impl<'a> BulkMetastoreModifyOperation<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
14 - impl<'a> BulkMetastoreModifyOperation<'a> {
14 + impl BulkMetastoreModifyOperation<'_> {
|
|
|
clippy
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|