Fixes for alpha #363
Merged
Fixes for alpha #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zanderb98
commented
Dec 30, 2023
zanderb98
commented
- Fixes for custom filters in UI
- Allow editing/creating custom filters
- Behavior settings to open subreddit options menu on tap
- Allow switching compact per subreddit in new subreddit options menu
- Fixes for compact mode per subreddit
- Use default compact mode for mixed (Saved) subreddit
zanderb98
force-pushed
the
fix-compact-post-dimensions-and-more
branch
3 times, most recently
from
0eac211 to
cec96e3
Compare
- Fixes for custom filters in UI - Allow editing/creating custom filters - Options to open menu on tap - Fixes for compact mode per subreddit - Use default compact mode for mixed (Saved) subreddit
zanderb98
force-pushed
the
fix-compact-post-dimensions-and-more
branch
from
cec96e3 to
3f97a14
Compare
ejbills
added a commit
that referenced
this pull request
Jan 14, 2024
* disable highlightedtexteditor since it has issues with predictive text atm * clear the text bg and also skip collapse bounce animation since im a genius * Fix go to Credentials empty space placeholder button * 1 Line * Uppercasing Theming folder * Extensions folder organization and enabling of asset ext generation * Improved iconPeak icon * Removed useless Color * Images to single scale * support old.reddit links on winston-everywhere * Moved AppContent to it’s own file * Removed TestersCelebration View file * Folders organization * Reenabled Onboarding opening (still lacking proper instructions) and added empty state for credentials list * fix Face ID auth (#369) * fix share button not presenting share sheet * remove fixed sizing for posts * Files organization * small optimizations and fixes for safari api cred assistant * Progress into making the onboarding * Small UI fixes * Optimistic version of credentials assistant is done + dropped iOS 17 support * Fixed iOS 17 bug * Finished adding new credentials for noobs + fixed api assistang overlap bugs * Onboarding integrated with new credential + a few fixes * Fixes scrolling to selected sub when opening comments * Removed line limit on profile page * Implemented TRUE swipe everywhere. Seems to be working fine * comment context * remove more frames * fix sub search crash * remove fixd badge size * Revert "remove more frames" This reverts commit 65f347e. * Revert "Revert "remove more frames"" This reverts commit be3005b. * fix comments being huge in the profile, probably * Removed stupid code * Fixed post images prefetching * Fixed reset nav path on tab tap * Fixed tab bar swipe conflicting with swipe anywhere * Reenabled loadedPosts deduplication feature * Fixed memory leak (who knows why) * Perf improvements * Fixed selection of selected credential * Fixed onboarding not being dismissed after saving cred * Changed method name * Added opened effect to postlinks * Fixed (WIP) image scales * Fix fix * refactor code for user profile viewing, issue isnt caused by this bit of code * wait for page to mark itself complete * Remove markdownosaur (#384) * better markdown rendering and replaced post collapse logic * no more markdownosaur * Disable Face ID Auth Option on MacOS (#374) * fixes * support IPad splitview + small fixes (#385) * comment skipper * Update PostReplies.swift * fix navigation (#386) * Fixes for alpha (#363) * Fixes for alpha - Fixes for custom filters in UI - Allow editing/creating custom filters - Options to open menu on tap - Fixes for compact mode per subreddit - Use default compact mode for mixed (Saved) subreddit * Use other vibration for edit filter and actionSize for buttons --------- Co-authored-by: Zander Bobronnikov <Zander.Bobronnikov@ibm.com> * fix load more comments not working post comment skipper changes * change markdown lib * put this back * fix linespacing (#388) * table format + filter nbsp (#391) * Fix blockquotes, and others in markdown (#392) Co-authored-by: Zander Bobronnikov <Zander.Bobronnikov@ibm.com> * Hide spoilers in comments and add show button for comments (#393) * Increase hitbox for subreddit options buttons * fix tab navpath reset * Add haptic feedback for compact/new filter buttons. Move comment skip… (#397) * Add haptic feedback for compact/new filter buttons. Move comment skipper to right side when using inline toolbar for easier right handed use * Remove VideoPlayer changes --------- Co-authored-by: Zander Bobronnikov <Zander.Bobronnikov@ibm.com> * 1.1.1 -> 1.1.2 * Create prettier.yml * Delete .github/workflows/prettier.yml * . * Revert "." This reverts commit c0ced68. * Revert "Revert "."" This reverts commit 5085c7d. --------- Co-authored-by: Igor Marcossi <igor@lo.cafe> Co-authored-by: sefidel <contact@sefidel.net> Co-authored-by: Nelson Dane <47427072+NelsonDane@users.noreply.github.com> Co-authored-by: Daniel <62436912+Frostplexx@users.noreply.github.com> Co-authored-by: rbertus2000 <91765399+rbertus2000@users.noreply.github.com> Co-authored-by: zanderb98 <zanderbob@gmail.com> Co-authored-by: Zander Bobronnikov <Zander.Bobronnikov@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.