Support for Redgifs video platform #539
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robigan
commented
Oct 2, 2024
There was a problem hiding this comment.
This might be worth evaluating before merging
|
Let me know if I need to increase build numbers or software versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for playback for the Redgifs video platform, which some friends of mine who use Winston asked me to implement 👀. I based my code off of the code for streamable.
There are some improvements I made in the code for handling redgifs which I think would be well deserved on streamable handler code. Technically, closes #534, but I think some extra handling of the Streamable URL wouldn't be too bad all in all. Maybe separate PR?
Closes #513