Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IS-14 rename and simplify #10

Merged
merged 3 commits into from
Sep 4, 2024
Merged

IS-14 rename and simplify #10

merged 3 commits into from
Sep 4, 2024

Conversation

jonathan-r-thorpe
Copy link
Collaborator

  • Changed ncp_nmos_resource_type to ncp_touchpoint_resource_type
  • Generalized find_control_protocol_resource (removed explicit references to Receiver resources)
  • Removed redundant parameters from get_control_class and get_datatype

lo-simon
lo-simon approved these changes Sep 4, 2024
View reviewed changes
Copy link
Owner

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit 9f68dbf into is-14 Sep 4, 2024
22 checks passed
@jonathan-r-thorpe jonathan-r-thorpe deleted the is-14-simplify branch September 10, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lo-simon lo-simon lo-simon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-r-thorpe @lo-simon