Fix/no account overwrite #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
requested changes
Jul 18, 2024
chadoh
approved these changes
Jul 18, 2024
|
Addressed Willem's comment, should be good to go! |
willemneal
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround while we wait for this to be fixed and released: stellar/stellar-cli#1380
This makes it so that
generatewill not be run if the account already exists. I usedkeys fundbecause its the only command underkeysthat actually hits the network. Presumably if one is testing on a local instance of stellar then their local identity files might be out of date so usingfundis the only way to guarantee they actually exist on the network that I'm aware of. If there is a better command to query the network for the existence of the key let me know and I will use that.