Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TECH-30764 Refactor the solution. Added Unit Test and fixed issues #14

Merged
merged 2 commits into from
Sep 17, 2024
Merged

TECH-30764 Refactor the solution. Added Unit Test and fixed issues #14

merged 2 commits into from
Sep 17, 2024

Conversation

AliArmanLMG
Copy link
Contributor

Linked ClickUp: TECH-30764

The challenge being addressed:

  1. Refactored the solution and added unit test for LixiPackageService
  2. Replaced serialized lixi pakcage sample with non serialized(as it should be able to serialized to Australia or New Zealand format)
  3. Added the country factor for serializing the packages before sending them to the endpoint as the solution will be used by lenders in Australia and New Zealand.

AndBeasley
AndBeasley requested changes Sep 16, 2024
View reviewed changes
Copy link

@AndBeasley AndBeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, left 1 question for name in lixi package

samples/MyCRM.Lodgement.Core/LixiPackageSamples/NewLoanApplication.json Outdated Show resolved Hide resolved
AndBeasley
AndBeasley approved these changes Sep 17, 2024
View reviewed changes
Copy link

@AndBeasley AndBeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AliArmanLMG AliArmanLMG merged commit b580b25 into master Sep 17, 2024
3 checks passed
@AliArmanLMG AliArmanLMG deleted the chore/TECH-30764-Refactor branch September 17, 2024 00:14
AliArmanLMG added a commit that referenced this pull request Sep 26, 2024
@AliArmanLMG
Revert "Merge pull request #14 from loanmarket/chore/TECH-30764-Refac…
6dbbb11 
…tor"

This reverts commit b580b25, reversing
changes made to 9ac4f81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndBeasley AndBeasley AndBeasley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AliArmanLMG @AndBeasley