Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF-68: Add New Nav Icons #430

Merged
merged 2 commits into from
Dec 20, 2023
Merged

SELF-68: Add New Nav Icons #430

merged 2 commits into from
Dec 20, 2023

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Dec 20, 2023

JIRA

Description

  • New icons for the updated Side Nav

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-68/add-new-nav-icons branch from 02be338 to c26aa82 Compare December 20, 2023 19:03
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-430.d11k469e311m4w.amplifyapp.com

Copy link
Contributor

@kencrim kencrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to rev version of package.json, and update the CHANGELOG.md, otherwise looks good

@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review December 20, 2023 19:15
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner December 20, 2023 19:15
@NateWaldschmidt NateWaldschmidt force-pushed the SELF-68/add-new-nav-icons branch from 7eb83e5 to 7a3ec01 Compare December 20, 2023 19:34
Copy link

guardrails bot commented Dec 20, 2023

⚠️ We detected 13 security issues in this pull request:

Vulnerable Libraries (13)
Severity Details
Medium pkg:npm/eslint@8.19.0 (t) upgrade to: > 8.19.0
Critical pkg:npm/vue-loader@16.8.3 (t) upgrade to: > 16.8.3
High pkg:npm/tailwindcss@3.1.6 (t) upgrade to: > 3.1.6
Medium pkg:npm/vue@3.2.37 (t) upgrade to: > 3.2.37
Critical pkg:npm/@storybook/addon-docs@6.5.9 (t) upgrade to: > 6.5.9
High pkg:npm/@babel/core@7.18.6 (t) upgrade to: > 7.18.6
Critical pkg:npm/babel-loader@8.2.5 (t) upgrade to: > 8.2.5
Critical pkg:npm/@storybook/vue3@6.5.9 (t) upgrade to: > 6.5.9
Critical pkg:npm/sass-loader@10.3.1 (t) upgrade to: > 10.3.1
Medium pkg:npm/vue-eslint-parser@7.11.0 (t) upgrade to: > 7.11.0
Medium pkg:npm/postcss@8.4.16 (t) upgrade to: 8.4.31
Critical pkg:npm/@storybook/addon-essentials@6.5.9 (t) upgrade to: > 6.5.9
Medium pkg:npm/eslint-plugin-vue@8.7.1 (t) upgrade to: > 8.7.1

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-68/add-new-nav-icons branch from 7a3ec01 to 9dcb9d8 Compare December 20, 2023 19:38
@NateWaldschmidt NateWaldschmidt merged commit e015ec2 into main Dec 20, 2023
4 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-68/add-new-nav-icons branch December 20, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants