Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELF-168: Fix NumberInput v-model #448

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Feb 15, 2024

JIRA

  • SELF-168

Description

  • Fixes v-model
  • Adds containerProps

NOTE: PrimeVue does NOT follow normal Vue conventions for their InputNumber component and v-model. I am personally not a fan of how they have chosen for this to work
primefaces/primevue#506

Tests

  • Adds tests to ensure the proper emits are happening

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

Copy link

guardrails bot commented Feb 15, 2024

⚠️ We detected 7 security issues in this pull request:

Vulnerable Libraries (7)
Severity Details
Medium pkg:npm/postcss@8.4.16 (t) upgrade to: 8.4.31
Medium pkg:npm/eslint-plugin-vue@8.7.1 (t) upgrade to: > 8.7.1
Critical pkg:npm/babel-loader@8.2.5 (t) upgrade to: > 8.2.5
Critical pkg:npm/sass-loader@10.3.1 (t) upgrade to: > 10.3.1
High pkg:npm/tailwindcss@3.1.6 (t) upgrade to: > 3.1.6
Medium pkg:npm/eslint@8.19.0 (t) upgrade to: > 8.19.0
Critical pkg:npm/vue-loader@16.8.3 (t) upgrade to: > 16.8.3

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-448.d11k469e311m4w.amplifyapp.com

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-168/fix-number-input-vmodel branch from 7ad80de to 4c9d840 Compare February 15, 2024 16:57
@NateWaldschmidt NateWaldschmidt force-pushed the SELF-168/fix-number-input-vmodel branch from 4c9d840 to f7aa57e Compare February 15, 2024 16:58
@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review February 15, 2024 17:37
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner February 15, 2024 17:37
@NateWaldschmidt NateWaldschmidt merged commit ab05f65 into main Feb 15, 2024
4 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-168/fix-number-input-vmodel branch February 15, 2024 17:38
@juanfriss
Copy link
Contributor

@NateWaldschmidt can you check this Cypress test?

image

@bethqiang
Copy link
Contributor

@juanfriss yeah, seems like the Cypress test error is because of this PR. I can fix it - we should probably be keying off the label anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants