Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor: refactor the service interface #2062

Merged
merged 5 commits into from
Apr 16, 2024
Merged

♻️ refactor: refactor the service interface #2062

merged 5 commits into from
Apr 16, 2024

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Apr 16, 2024 •
edited
Loading

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

重构 service 接口定义，让 server Service 的接口尽量与 client 对齐

  • session
  • file
  • message
  • topic
  • user
  • plugin

📝 补充信息 | Additional Information

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-community ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:03am

@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@arvinxx arvinxx changed the title ♻️ refactor: refactor the session service interface ♻️ refactor: refactor the service interface Apr 16, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.11215% with 34 lines in your changes missing coverage. Please review.

Project coverage is 93.10%. Comparing base (bfe3c98) to head (86bc53c).
Report is 1432 commits behind head on main.

Files with missing lines Patch % Lines
src/services/file/client.ts 42.85% 20 Missing ⚠️
src/services/topic/client.ts 87.09% 4 Missing ⚠️
src/services/message/index.ts 86.36% 3 Missing ⚠️
src/database/client/models/session.ts 50.00% 2 Missing ⚠️
src/services/session/client.ts 93.33% 2 Missing ⚠️
src/store/chat/slices/message/action.ts 75.00% 1 Missing ⚠️
src/store/chat/slices/topic/action.ts 85.71% 1 Missing ⚠️
src/store/session/slices/session/action.ts 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2062      +/-   ##
==========================================
+ Coverage   92.80%   93.10%   +0.29%     
==========================================
  Files         264      264              
  Lines       14821    14883      +62     
  Branches     1706     1043     -663     
==========================================
+ Hits        13755    13857     +102     
+ Misses       1066     1026      -40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lobehub lobehub deleted a comment from lobehubbot Apr 16, 2024
@arvinxx arvinxx merged commit 86779e2 into main Apr 16, 2024
9 of 10 checks passed
@arvinxx arvinxx deleted the refactor/server-interface branch April 16, 2024 09:09
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
@semantic-release-bot
🔖 chore(release): v0.147.17 [skip ci]
40507dd 
### [Version 0.147.17](v0.147.16...v0.147.17)
<sup>Released on **2024-04-16**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor service to a uniform interface.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor service to a uniform interface, closes [#2062](#2062) ([86779e2](86779e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 0.147.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Apr 16, 2024
@semantic-release-bot
🔖 chore(release): v1.27.17 [skip ci]
9b3410f 
### [Version&nbsp;1.27.17](v1.27.16...v1.27.17)
<sup>Released on **2024-04-16**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor service to a uniform interface.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor service to a uniform interface, closes [lobehub#2062](https://github.com/bentwnghk/lobe-chat/issues/2062) ([86779e2](86779e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
TheNameIsNigel pushed a commit to TheNameIsNigel/lobe-chat that referenced this pull request May 15, 2024
@arvinxx @TheNameIsNigel
♻️ refactor: refactor service to a uniform interface (lobehub#2062)
e6a3d51 
* ♻️ refactor: refactor the session service interface

* ♻️ refactor: add file service interface

* ♻️ refactor: add message service interface

* ♻️ refactor: add topic service interface

* ✅ test: add test for agent action
TheNameIsNigel pushed a commit to TheNameIsNigel/lobe-chat that referenced this pull request May 15, 2024
@semantic-release-bot @TheNameIsNigel
🔖 chore(release): v0.147.17 [skip ci]
744f623 
### [Version&nbsp;0.147.17](lobehub/lobe-chat@v0.147.16...v0.147.17)
<sup>Released on **2024-04-16**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor service to a uniform interface.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor service to a uniform interface, closes [lobehub#2062](lobehub#2062) ([86779e2](lobehub@86779e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@arvinxx @ipoly
♻️ refactor: refactor service to a uniform interface (lobehub#2062)
2a8b32b 
* ♻️ refactor: refactor the session service interface

* ♻️ refactor: add file service interface

* ♻️ refactor: add message service interface

* ♻️ refactor: add topic service interface

* ✅ test: add test for agent action
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@semantic-release-bot @ipoly
🔖 chore(release): v0.147.17 [skip ci]
1de5e2e 
### [Version&nbsp;0.147.17](lobehub/lobe-chat@v0.147.16...v0.147.17)
<sup>Released on **2024-04-16**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor service to a uniform interface.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor service to a uniform interface, closes [lobehub#2062](lobehub#2062) ([86779e2](lobehub@86779e2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot