-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 style: fix footer being cut on wide screen #2905
Conversation
Thank you for raising your pull request and contributing to our Community |
@phuctm97 Nice catch! could you please add a screenshot of before and after? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2905 +/- ##
========================================
Coverage 93.25% 93.25%
========================================
Files 380 380
Lines 23795 23795
Branches 2543 2665 +122
========================================
Hits 22190 22190
Misses 1605 1605
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution!
❤️ Great PR @phuctm97 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.0.6](v1.0.5...v1.0.6) <sup>Released on **2024-06-17**</sup> #### 💄 Styles - **misc**: Fix footer being cut on wide screen. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Styles * **misc**: Fix footer being cut on wide screen, closes [#2905](#2905) ([3a1e0cf](3a1e0cf)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
🎉 This PR is included in version 1.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
### [Version 1.43.1](v1.43.0...v1.43.1) <sup>Released on **2024-06-17**</sup> #### 🐛 Bug Fixes - **misc**: Fix clerk `UNAUTHORIZED` auth error, fix onboard and auth for community version, openai key and openai proxy are invalid in feature flags. #### 💄 Styles - **misc**: Add stepfun as a new provider, fix footer being cut on wide screen. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix clerk `UNAUTHORIZED` auth error, closes [lobehub#2907](https://github.com/bentwnghk/lobe-chat/issues/2907) ([bb33ba4](bb33ba4)) * **misc**: Fix onboard and auth for community version, closes [lobehub#2908](https://github.com/bentwnghk/lobe-chat/issues/2908) ([b02020d](b02020d)) * **misc**: Openai key and openai proxy are invalid in feature flags, closes [lobehub#2886](https://github.com/bentwnghk/lobe-chat/issues/2886) ([ec4f481](ec4f481)) #### Styles * **misc**: Add stepfun as a new provider, closes [lobehub#2803](https://github.com/bentwnghk/lobe-chat/issues/2803) ([e1989a1](e1989a1)) * **misc**: Fix footer being cut on wide screen, closes [lobehub#2905](https://github.com/bentwnghk/lobe-chat/issues/2905) ([3a1e0cf](3a1e0cf)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
### [Version 1.0.6](lobehub/lobe-chat@v1.0.5...v1.0.6) <sup>Released on **2024-06-17**</sup> #### 💄 Styles - **misc**: Fix footer being cut on wide screen. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Styles * **misc**: Fix footer being cut on wide screen, closes [lobehub#2905](lobehub#2905) ([3a1e0cf](lobehub@3a1e0cf)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
On wide screen, footer in welcome page being cut because the content overflows the screen height. This makes sure the content doesn't overflow to the footer space.