Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: hydration mismatch on Mac #2913

Merged
merged 1 commit into from
Jun 18, 2024
Merged

🐛 fix: hydration mismatch on Mac #2913

merged 1 commit into from
Jun 18, 2024

Conversation

phuctm97
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

On MacOS, there will be a hydration issue on the hotkey indicators because isMacOS() function returns different value on server & client. This delays rendering them after hydration with proper loading during SSR.

@lobehubbot
Copy link
Member

👍 @phuctm97

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (4229e4f) to head (4aecd67).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #2913    +/-   ##
========================================
  Coverage   93.27%   93.27%            
========================================
  Files         382      382            
  Lines       23878    23878            
  Branches     2668     1870   -798     
========================================
  Hits        22273    22273            
  Misses       1605     1605
Flag Coverage Δ
app 93.27% <ø> (ø)
server 66.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arvinxx
arvinxx approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@arvinxx arvinxx merged commit cd9a143 into lobehub:main Jun 18, 2024
6 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @phuctm97 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@semantic-release-bot
🔖 chore(release): v1.0.8 [skip ci]
d13d64c 
### [Version&nbsp;1.0.8](v1.0.7...v1.0.8)
<sup>Released on **2024-06-18**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix hydration mismatch on macOS.

#### 💄 Styles

- **misc**: Update brand and improve docs.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix hydration mismatch on macOS, closes [#2913](#2913) ([cd9a143](cd9a143))

#### Styles

* **misc**: Update brand and improve docs, closes [#2917](#2917) ([2b54cae](2b54cae))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jun 18, 2024
@semantic-release-bot
🔖 chore(release): v1.43.3 [skip ci]
adc2ae2 
### [Version&nbsp;1.43.3](v1.43.2...v1.43.3)
<sup>Released on **2024-06-18**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix hydration mismatch on macOS.

#### 💄 Styles

- **misc**: Update brand and improve docs.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix hydration mismatch on macOS, closes [lobehub#2913](https://github.com/bentwnghk/lobe-chat/issues/2913) ([cd9a143](cd9a143))

#### Styles

* **misc**: Update brand and improve docs, closes [lobehub#2917](https://github.com/bentwnghk/lobe-chat/issues/2917) ([2b54cae](2b54cae))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 1, 2024
@phuctm97 @Mingholy
🐛 fix: fix hydration mismatch on macOS (lobehub#2913)
913a7b0
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 1, 2024
@semantic-release-bot @Mingholy
🔖 chore(release): v1.0.8 [skip ci]
bcb386f 
### [Version&nbsp;1.0.8](lobehub/lobe-chat@v1.0.7...v1.0.8)
<sup>Released on **2024-06-18**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix hydration mismatch on macOS.

#### 💄 Styles

- **misc**: Update brand and improve docs.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix hydration mismatch on macOS, closes [lobehub#2913](lobehub#2913) ([cd9a143](lobehub@cd9a143))

#### Styles

* **misc**: Update brand and improve docs, closes [lobehub#2917](lobehub#2917) ([2b54cae](lobehub@2b54cae))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@phuctm97 @ipoly
🐛 fix: fix hydration mismatch on macOS (lobehub#2913)
4a9b6a4
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
@semantic-release-bot @ipoly
🔖 chore(release): v1.0.8 [skip ci]
faf805c 
### [Version&nbsp;1.0.8](lobehub/lobe-chat@v1.0.7...v1.0.8)
<sup>Released on **2024-06-18**</sup>

#### 🐛 Bug Fixes

- **misc**: Fix hydration mismatch on macOS.

#### 💄 Styles

- **misc**: Update brand and improve docs.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix hydration mismatch on macOS, closes [lobehub#2913](lobehub#2913) ([cd9a143](lobehub@cd9a143))

#### Styles

* **misc**: Update brand and improve docs, closes [lobehub#2917](lobehub#2917) ([2b54cae](lobehub@2b54cae))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvinxx arvinxx arvinxx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phuctm97 @lobehubbot @arvinxx