Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: Remove brackets from model names with dates in OpenAI #3927

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

LovelyGuYiMeng
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

规整模型中带日期的名称,与其他provider显示日期格式相同

📝 补充信息 | Additional Information

Copy link

vercel bot commented Sep 12, 2024

@LovelyGuYiMeng is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 12, 2024
@lobehubbot
Copy link
Member

👍 @LovelyGuYiMeng

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 💄 Design Design an style | 样式问题 label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (0cfee6b) to head (a9e852e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3927    +/-   ##
========================================
  Coverage   92.07%   92.07%            
========================================
  Files         460      460            
  Lines       31542    31542            
  Branches     2999     2004   -995     
========================================
  Hits        29043    29043            
  Misses       2499     2499            
Flag Coverage Δ
app 92.07% <100.00%> (ø)
server 97.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sxjeru
Copy link
Contributor

sxjeru commented Sep 12, 2024

年份会不会保留比较好,当 model id 也有年份时。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Would it be better to keep the year?

@LovelyGuYiMeng
Copy link
Contributor Author

年份会不会保留比较好,当 model id 也有年份时。

带年份就显得不工整好看了

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Would it be better to retain the year when the model id also has a year?

With the year on it, it looks untidy and nice.

@sxjeru
Copy link
Contributor

sxjeru commented Sep 12, 2024

好看可能还是实用更重要,如果是为了好看,那么改自己仓库的就行,应该不用提 pr 了。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Good looks may be more important than practicality. If it is for good looks, then just change it to your own warehouse, and there should be no need to mention PR.

@LovelyGuYiMeng
Copy link
Contributor Author

LovelyGuYiMeng commented Sep 12, 2024

好看可能还是实用更重要,如果是为了好看,那么改自己仓库的就行,应该不用提 pr 了。

带不带年份影响都不大,而且选中模型后,上方显示的是模型ID,照样能看到年份
像千问,谷歌预览都不带年份

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Good-looking may be more important than practicality. If it is for good-looking, then just change it to your own warehouse, and there should be no need to mention PR.

Whether it has a year or not has little impact, and after selecting the model, the model ID is displayed above, and the year can still be seen.

@arvinxx arvinxx merged commit 2a937bc into lobehub:main Sep 12, 2024
5 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @LovelyGuYiMeng ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
### [Version&nbsp;1.16.12](v1.16.11...v1.16.12)
<sup>Released on **2024-09-12**</sup>

#### 💄 Styles

- **misc**: Remove brackets from model names with dates in OpenAI.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Remove brackets from model names with dates in OpenAI, closes [#3927](#3927) ([2a937bc](2a937bc))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.16.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@LovelyGuYiMeng LovelyGuYiMeng deleted the patch-1 branch September 12, 2024 16:28
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Sep 13, 2024
## [Version&nbsp;1.60.0](v1.59.4...v1.60.0)
<sup>Released on **2024-09-13**</sup>

#### ♻ Code Refactoring

- **misc**: Support Environment Variable Inference For NextAuth.

#### ✨ Features

- **misc**: Support openai new OpenAI o1-preview/o1-mini models.

#### 🐛 Bug Fixes

- **misc**: Qwen model param error, support webhooks for logto.

#### 💄 Styles

- **model**: Remove `OpenAI` deprecated model.
- **misc**: Default disable mistral provider useless models, Remove brackets from model names with dates in OpenAI, Support Google Model List, Update siliconcloud model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Support Environment Variable Inference For NextAuth, closes [lobehub#3701](https://github.com/bentwnghk/lobe-chat/issues/3701) ([b956755](b956755))

#### What's improved

* **misc**: Support openai new OpenAI o1-preview/o1-mini models, closes [lobehub#3943](https://github.com/bentwnghk/lobe-chat/issues/3943) ([61bfeb2](61bfeb2))

#### What's fixed

* **misc**: Qwen model param error, closes [lobehub#3902](https://github.com/bentwnghk/lobe-chat/issues/3902) ([c9f00e5](c9f00e5))
* **misc**: Support webhooks for logto, closes [lobehub#3774](https://github.com/bentwnghk/lobe-chat/issues/3774) ([0cfee6b](0cfee6b))

#### Styles

* **model**: Remove `OpenAI` deprecated model, closes [lobehub#3465](https://github.com/bentwnghk/lobe-chat/issues/3465) ([68a4fb2](68a4fb2))
* **misc**: Default disable mistral provider useless models, closes [lobehub#3922](https://github.com/bentwnghk/lobe-chat/issues/3922) ([bdbc647](bdbc647))
* **misc**: Remove brackets from model names with dates in OpenAI, closes [lobehub#3927](https://github.com/bentwnghk/lobe-chat/issues/3927) ([2a937bc](2a937bc))
* **misc**: Support Google Model List, closes [lobehub#3938](https://github.com/bentwnghk/lobe-chat/issues/3938) ([be4efc7](be4efc7))
* **misc**: Update siliconcloud model, closes [lobehub#3935](https://github.com/bentwnghk/lobe-chat/issues/3935) ([882e981](882e981))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
cy948 pushed a commit to cy948/lobe-chat that referenced this pull request Sep 21, 2024
…ub#3927)

* Update openai.ts

* Update index.test.ts.snap

* Update index.test.ts.snap
cy948 pushed a commit to cy948/lobe-chat that referenced this pull request Sep 21, 2024
### [Version&nbsp;1.16.12](lobehub/lobe-chat@v1.16.11...v1.16.12)
<sup>Released on **2024-09-12**</sup>

#### 💄 Styles

- **misc**: Remove brackets from model names with dates in OpenAI.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Remove brackets from model names with dates in OpenAI, closes [lobehub#3927](lobehub#3927) ([2a937bc](lobehub@2a937bc))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💄 Design Design an style | 样式问题 released size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants