Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› fix: disregard remoteModelCards when showModelFetcher is disabled #4644

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

BrandonStudio
Copy link
Contributor

@BrandonStudio BrandonStudio commented Nov 8, 2024

πŸ’» ε˜ζ›΄η±»εž‹ | Change Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ‘· build
  • ⚑️ perf
  • πŸ“ docs
  • πŸ”¨ chore

πŸ”€ ε˜ζ›΄θ―΄ζ˜Ž | Description of Change

Disregard remoteModelCards when showModelFetcher is disabled

πŸ“ θ‘₯充俑息 | Additional Information

Fix #4547 (2/3).

Copy link

vercel bot commented Nov 8, 2024

@BrandonStudio is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 92.40%. Comparing base (e1f6a3a) to head (b68ff2b).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4644      +/-   ##
==========================================
- Coverage   92.48%   92.40%   -0.08%     
==========================================
  Files         511      511              
  Lines       36614    36615       +1     
  Branches     3388     3539     +151     
==========================================
- Hits        33862    33834      -28     
- Misses       2752     2781      +29     
Flag Coverage Ξ”
app 92.40% <100.00%> (-0.08%) ⬇️
server 97.26% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@arvinxx arvinxx changed the title Disregard remoteModelCards when showModelFetcher is disabled πŸ› fix: disregard remoteModelCards when showModelFetcher is disabled Nov 8, 2024
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-preview βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 8, 2024 4:43pm

@arvinxx arvinxx merged commit a4431f2 into lobehub:main Nov 9, 2024
7 of 9 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 9, 2024
### [Version&nbsp;1.29.4](v1.29.3...v1.29.4)
<sup>Released on **2024-11-09**</sup>

#### πŸ› Bug Fixes

- **misc**: Disregard remoteModelCards when showModelFetcher is disabled.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Disregard remoteModelCards when showModelFetcher is disabled, closes [#4644](#4644) ([a4431f2](a4431f2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Nov 9, 2024
### [Version&nbsp;1.72.3](v1.72.2...v1.72.3)
<sup>Released on **2024-11-09**</sup>

#### πŸ› Bug Fixes

- **misc**: Disregard remoteModelCards when showModelFetcher is disabled.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Disregard remoteModelCards when showModelFetcher is disabled, closes [lobehub#4644](https://github.com/bentwnghk/lobe-chat/issues/4644) ([a4431f2](a4431f2))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@BrandonStudio BrandonStudio deleted the refactor/remote-fetch branch November 9, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "Get Model List" clears out Github models
2 participants