-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
๐ style: Add avatar for server database upload to S3, removing SSO dependency for avatar management #7152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
๐ @RICHQAQ Thank you for raising your pull request and contributing to our Community |
@RICHQAQ is attempting to deploy a commit to the LobeChat Desktop Team on Vercel. A member of the Team first needs to authorize it. |
I believe that some information, such as avatars, doesnโt need to be tightly synced with the SSO provider. Just like many apps (e.g., WeChat, Google login), the username and avatar can be modified directly by the user without affecting the authentication service. This separation allows for a more flexible and user-friendly experience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! There is some part need to be improved~
Codecov ReportAll modified and coverable lines are covered by tests โ
Additional details and impacted files@@ Coverage Diff @@
## main #7152 +/- ##
==========================================
+ Coverage 89.26% 95.74% +6.48%
==========================================
Files 790 14 -776
Lines 57272 2492 -54780
Branches 5291 238 -5053
==========================================
- Hits 51122 2386 -48736
+ Misses 6150 106 -6044
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. ๐ New features to boost your workflow:
|
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
I'm working on the desktop version,and it turns out to be a must to sync user avatar from the api. So I'll take it ASAP. |
Please rebase the main |
โฆivate S3 bucket, use UUID to generate unique file names, and delete the old avatar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase the main
Is this implementation acceptable, or would you like me to make any changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for your contribution!
โค๏ธ Great PR @RICHQAQ โค๏ธ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.82.5](v1.82.4...v1.82.5) <sup>Released on **2025-04-24**</sup> #### ๐ Bug Fixes - **misc**: Countries-and-timezones return invalid timezone. #### ๐ Styles - **misc**: Add avatar for server database upload to S3, removing SSO dependency for avatar management. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Countries-and-timezones return invalid timezone, closes [#7539](#7539) [#7518](#7518) [#7542](#7542) ([bdb44a8](bdb44a8)) #### Styles * **misc**: Add avatar for server database upload to S3, removing SSO dependency for avatar management, closes [#7152](#7152) ([f15200d](f15200d)) </details> <div align="right"> [](#readme-top) </div>
๐ This PR is included in version 1.82.5 ๐ The release is available on: Your semantic-release bot ๐ฆ๐ |
๐ป ๅๆด็ฑปๅ | Change Type
๐ ๅๆด่ฏดๆ | Description of Change
This PR introduces a feature that allows direct upload of avatars to S3 for the server database version. Previously, avatar changes had to be made through the SSO provider, which was a cumbersome process. With the new implementation, users can now upload avatars directly to S3 and store the image URL in the database, removing the SSO dependency for avatar management. Other data will still remain synchronized with the SSO provider.
๐ ่กฅๅ ไฟกๆฏ | Additional Information
No other functionality was affected. Only the avatar-related mechanism has been modified, making the process more efficient and user-friendly.