Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŒ style: Add Vietnamese files and add the vi-VN option in the General Settings #860

Merged
merged 9 commits into from
Jan 3, 2024
Merged

Conversation

CongLeSolutionX
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore: Add Vietnamese files and add the vi-VN option in the General Settings
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  • Inside locales folder, I added a folder vi-VN. Inside that folder, I added the same json files used to support languges:
    • chat.json
    • common.json
    • empty.json
    • error.json
    • market.json
    • migration.json
    • plugin.json
    • setting.json
    • tool.json
    • welcom.json
  • Inside each of those json file, I translated all the pairs of value to support Vietnamese.
  • Inside file src/locales/resources.ts, I added code to support Vietnames, loading data from folder vi-VN.

๐Ÿ“ Demo:

demo-better

Copy link

vercel bot commented Dec 29, 2023

@CongLeSolutionX is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

๐Ÿ‘ @CongLeSolutionX

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

CongLeSolutionX and others added 2 commits December 28, 2023 21:51
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the vi-VN into the i18nrc.js and run npm run i18n.

https://github.com/lobehub/lobe-chat/blob/main/.i18nrc.js#L7

we won't update the i18n manually. So we use lobe-i18n to auto translate locale.

You can check simmiliar pr like: #759

src/app/layout.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests โœ…

Comparison is base (ab0aeb7) 87.37% compared to head (ef67736) 84.95%.
Report is 1 commits behind head on main.

โ— Current head ef67736 differs from pull request most recent head 3b85344. Consider uploading reports for the commit 3b85344 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   87.37%   84.95%   -2.42%     
==========================================
  Files         173      167       -6     
  Lines        7801     7506     -295     
  Branches      857      760      -97     
==========================================
- Hits         6816     6377     -439     
- Misses        985     1129     +144     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@CongLeSolutionX
Copy link
Contributor Author

please add the vi-VN into the i18nrc.js and run npm run i18n.

https://github.com/lobehub/lobe-chat/blob/main/.i18nrc.js#L7

we won't update the i18n manually. So we use lobe-i18n to auto translate locale.

You can check simmiliar pr like: #759

Thanks for your feedback, let me update this PR

@CongLeSolutionX
Copy link
Contributor Author

please add the vi-VN into the i18nrc.js and run npm run i18n.

https://github.com/lobehub/lobe-chat/blob/main/.i18nrc.js#L7

we won't update the i18n manually. So we use lobe-i18n to auto translate locale.

You can check simmiliar pr like: #759

Hi @arvinxx,
I follow your instructions to use .i18nrc.js to translate all files in the vi-VN folder.
.i18nrc.js also picks up the missing string "downloading" as well, so I add those changes to this PR.

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great job!

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jan 3, 2024 8:59am

@arvinxx arvinxx changed the title ๐Ÿ”จ chore: Add Vietnamese files and add the vi-VN option in the General Settings ๐ŸŒ style: Add Vietnamese files and add the vi-VN option in the General Settings Jan 3, 2024
@arvinxx arvinxx merged commit c2e5606 into lobehub:main Jan 3, 2024
3 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @CongLeSolutionX โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Jan 3, 2024
### [Version 0.118.8](v0.118.7...v0.118.8)
<sup>Released on **2024-01-03**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Add Vietnamese files and add the vi-VN option in the General Settings.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add Vietnamese files and add the vi-VN option in the General Settings, closes [#860](#860) ([c2e5606](c2e5606))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 0.118.8 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jan 3, 2024
### [Version&nbsp;1.0.15](v1.0.14...v1.0.15)
<sup>Released on **2024-01-03**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Add Vietnamese files and add the vi-VN option in the General Settings.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add Vietnamese files and add the vi-VN option in the General Settings, closes [lobehub#860](https://github.com/bentwnghk/lobe-chat/issues/860) ([c2e5606](c2e5606))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
miroshar-success added a commit to miroshar-success/OpenAI_Integraion_platform that referenced this pull request Apr 5, 2024
### [Version&nbsp;0.118.8](lobehub/lobe-chat@v0.118.7...v0.118.8)
<sup>Released on **2024-01-03**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Add Vietnamese files and add the vi-VN option in the General Settings.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Add Vietnamese files and add the vi-VN option in the General Settings, closes [#860](lobehub/lobe-chat#860) ([c2e5606](lobehub/lobe-chat@c2e5606))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants