Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

Adjust transformation of publication statement for RDA records #743

Closed
acka47 opened this issue Oct 22, 2015 · 5 comments
Closed

Adjust transformation of publication statement for RDA records #743

acka47 opened this issue Oct 22, 2015 · 5 comments
Assignees

Comments

@acka47
Copy link
Contributor

acka47 commented Oct 22, 2015

From hbz/lobid#161 (comment). Publication place, publisher and publication date are in 419.

Snippet from http://lobid.org/resource/HT018779822:

<datafield ind2="1" ind1="-" tag="419">
            <subfield code="a">New York</subfield>
            <subfield code="b">Routledge</subfield>
            <subfield code="c">2014</subfield>
</datafield>

Snippet from http://lobid.org/resource/HT018772912:

          <datafield ind2="1" ind1="-" tag="419">
            <subfield code="a">Sundern</subfield>
            <subfield code="b">Baulmann Leuchten GmbH</subfield>
            <subfield code="c">2011-</subfield>
            <subfield code="A">3</subfield>
          </datafield>

Also, publicationStatement has the wrong value in RDA records (only the date), for example http://lobid.org/resource/HT018779822:

{
  "@graph" : [ {
    "@id" : "http://lobid.org/resource/HT018779822",
    "@type" : [ "http://purl.org/dc/terms/BibliographicResource", "http://purl.org/ontology/bibo/Book" ],
    "publicationStatement" : "2014"
    } ]
}
@dr0i dr0i added the ready label Oct 22, 2015
dr0i added a commit that referenced this issue Oct 28, 2015
Treat field 419 in parallel to the MAB fields.
See #743.

- adjust tests
@dr0i dr0i added working and removed ready labels Oct 29, 2015
@dr0i
Copy link
Member

dr0i commented Oct 29, 2015

Deployed to staging.

@dr0i dr0i assigned acka47 and unassigned dr0i Oct 29, 2015
@dr0i dr0i added review and removed working labels Oct 29, 2015
@acka47
Copy link
Contributor Author

acka47 commented Oct 29, 2015

+1 for publicationStatement. What we also need to add are fields publisher and placeOfPublication. For http://lobid.org/resource/HT018779822 the result should look like this (snippet):

{
    "@id" : "http://lobid.org/resource/HT018779822",
    "issued" : "2014",
    "publicationStatement" : "New York; Routledge; 2014",
    "publisher": "Routledge",
    "placeOfPublication": "New York"
}

@acka47 acka47 added working and removed review labels Oct 29, 2015
@acka47 acka47 assigned dr0i and unassigned acka47 Oct 29, 2015
dr0i added a commit that referenced this issue Oct 29, 2015
See #743.

Introduce variables for reuse. Handle RDA fields in parallel to MAB2.

- adjust tests
@dr0i dr0i mentioned this issue Oct 29, 2015
@dr0i
Copy link
Member

dr0i commented Oct 30, 2015

Deployed to staging.

@dr0i dr0i assigned acka47 and unassigned dr0i Oct 30, 2015
@dr0i dr0i removed the processing label Oct 30, 2015
@acka47
Copy link
Contributor Author

acka47 commented Oct 30, 2015

+1

@acka47 acka47 added the deploy label Oct 30, 2015
@acka47 acka47 removed the review label Oct 30, 2015
@acka47 acka47 assigned dr0i and unassigned acka47 Oct 30, 2015
@dr0i
Copy link
Member

dr0i commented Nov 2, 2015

Deployed to production, closing.

@dr0i dr0i closed this as completed Nov 2, 2015
@dr0i dr0i removed the deploy label Nov 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants