Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Artifacts framework to install binary dependencies #36

Merged
merged 6 commits into from
Dec 7, 2019
Merged

Use new Artifacts framework to install binary dependencies #36

merged 6 commits into from
Dec 7, 2019

Conversation

giordano
Copy link
Contributor

This is not meant to be merged now, it's just for testing

@giordano
Copy link
Contributor Author

giordano commented Oct 10, 2019 •
edited
Loading

Travis on macOS is running deps/build.jl 😳 This is crazy, the file is not in this branch! A colleague today experienced problems with Travis picking up a wrong branch for testing (or is it GitHub messing up things?) Those messages probably came from building Cairo, not Rsvg

davidanthoff
davidanthoff reviewed Oct 10, 2019
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
@giordano giordano force-pushed the artifacts branch 4 times, most recently from 645c27b to 8f50557 Compare October 11, 2019 09:42
davidanthoff
davidanthoff requested changes Nov 28, 2019
View reviewed changes
Copy link
Collaborator

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, now that Cairo.jl is merged, lets move this forward :)

.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
Project.toml Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
@davidanthoff davidanthoff mentioned this pull request Nov 28, 2019
Closed
@giordano
Copy link
Contributor Author

Ok, I should have fixed merge conflicts that prevented CI from running before

@giordano giordano marked this pull request as ready for review November 30, 2019 17:34
@giordano giordano closed this Dec 1, 2019
@giordano giordano reopened this Dec 1, 2019
@davidanthoff
Copy link
Collaborator

Looks like there is still a merge conflict?

@giordano
Copy link
Contributor Author

giordano commented Dec 1, 2019

After the new commits to master, yes. I'll fix in the next few days

@davidanthoff davidanthoff merged commit 53f0946 into lobingera:master Dec 7, 2019
@giordano giordano deleted the artifacts branch December 7, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giordano @davidanthoff