fix(simplify): fix conditional expression pattern match transformatio…

…n logic (babel#754)
loborobo · Dec 11, 2017 · 033d9ab · 033d9ab
1 parent 37064b4
commit 033d9ab
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/packages/babel-plugin-minify-simplify/__tests__/simplify-test.js b/packages/babel-plugin-minify-simplify/__tests__/simplify-test.js
@@ -1969,6 +1969,36 @@ describe("simplify-plugin", () => {
   `
   );
 
+  thePlugin(
+    "should simplify common conditional operations 2",
+    `
+      function h1() { return a && b ? (foo(), true) : false }
+    `,
+    `
+      function h1() {
+        return !!(a && b) && (foo(), true);
+      }
+    `
+  );
+
+  thePlugin(
+    "should fix issue#689",
+    `
+      function foo(object, property, value) {
+        if (object && property) {
+          object[property] = value;
+          return true;
+        }
+        return false;
+      }
+    `,
+    `
+      function foo(object, property, value) {
+        return !!(object && property) && (object[property] = value, true);
+      }
+    `
+  );
+
   // From UglifyJS
   thePlugin.inEachLine(
     "should simplify logical expression of the following forms of && by compressing to the right",

diff --git a/packages/babel-plugin-minify-simplify/src/conditional-expression.js b/packages/babel-plugin-minify-simplify/src/conditional-expression.js
@@ -31,7 +31,7 @@ module.exports = t => {
 
       [EX, EX, true, (e, c) => or(not(e), c)],
 
-      [LE, EX, false, (e, c) => and(e, c)],
+      [LE, EX, false, (e, c) => and(notnot(e), c)],
       [EX, EX, false, (e, c) => and(notnot(e), c)]
     ]);