Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An update dialog skelton #364

Merged
merged 3 commits into from
Jul 2, 2023
Merged

An update dialog skelton #364

merged 3 commits into from
Jul 2, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Jul 1, 2023 •
edited
Loading

スクリーンショット 2023-07-01 16 17 11

@umireon umireon requested a review from royshil July 1, 2023 08:59
royshil
royshil approved these changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm loving it
but we shouldn't show this to the users right now
so we can keep it here on main, just don't add it to the plugin startup
we will build the version checker and the dialog itself, and then we can add it the startup

@umireon
Copy link
Member Author

umireon commented Jul 2, 2023

@royshil Can you create a new topic branch for a version checker? I will merge this into that branch.

@royshil
Copy link
Collaborator

royshil commented Jul 2, 2023

@royshil Can you create a new topic branch for a version checker? I will merge this into that branch.

you can certainly merge all of this on main for now, but we will connect the plugin startup code in a bit after we bring in the other libcurl part

@umireon
Copy link
Member Author

umireon commented Jul 2, 2023

@royshil I have removed the code of this PR from plugin-main.c. Is this what you mean?

@royshil
Copy link
Collaborator

royshil commented Jul 2, 2023

@royshil I have removed the code of this PR from plugin-main.c. Is this what you mean?

@umireon yes. we're good now!

@umireon umireon merged commit fc748c9 into main Jul 2, 2023
@umireon umireon deleted the umireon.dialog-skelton branch July 2, 2023 19:05
@umireon umireon added this to the v1.0.4 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royshil royshil royshil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@umireon @royshil