Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple mode for settings #443

Merged
merged 12 commits into from
Dec 15, 2023
Merged

Adding simple mode for settings #443

merged 12 commits into from
Dec 15, 2023

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Sep 21, 2023

By default the plugin will not show all settings, which may be scary for most users
I added an "Advanced mode" checkbox which will reveal all settings

@royshil royshil self-assigned this Sep 21, 2023
@royshil royshil added enhancement New feature or request Seeking Testers labels Sep 21, 2023
@umireon
Copy link
Member

umireon commented Sep 22, 2023

@royshil

Some settings are shown in the initial state.
スクリーンショット 2023-09-22 22 06 24

All settings are shown when the advanced settings are checked.
スクリーンショット 2023-09-22 22 06 31

Things are odd when the advanced settings are unchecked. All the settings except the Focul blur factor are gone.
スクリーンショット 2023-09-22 22 06 35

Is this behaviour is expected?

@umireon
Copy link
Member

umireon commented Sep 29, 2023

@royshil ping

@umireon
Copy link
Member

umireon commented Oct 4, 2023

@royshil ping

@royshil royshil added this to the 1.1.8 milestone Dec 13, 2023
@royshil
Copy link
Collaborator Author

royshil commented Dec 13, 2023

@umireon can you check on your end that it works properly now? 🙏

@royshil
Copy link
Collaborator Author

royshil commented Dec 15, 2023

@umireon ping

Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royshil royshil merged commit 4f3180a into main Dec 15, 2023
6 checks passed
@royshil royshil deleted the roy.add_simple_mode_settings branch December 15, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Seeking Testers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants