Skip to content

Commit

Permalink
Merge pull request #15 from Destroy666x/fix/WindowsCUDACompilationHel…
Browse files Browse the repository at this point in the history
…pers

fix: Windows CUDA compilation was incorrectly described
  • Loading branch information
royshil authored Sep 19, 2023
2 parents 6979c49 + 333ee8e commit c04565e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/scripts/Build-Windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ param(
[switch] $SkipAll,
[switch] $SkipBuild,
[switch] $SkipDeps,
[string] $ExtraCmakeArgs
[string[]] $ExtraCmakeArgs
)

$ErrorActionPreference = 'Stop'
Expand Down Expand Up @@ -58,7 +58,7 @@ function Build {
Ensure-Location $ProjectRoot

# take cmake args from $ExtraCmakeArgs
$CmakeArgs = @($ExtraCmakeArgs)
$CmakeArgs = $ExtraCmakeArgs
$CmakeBuildArgs = @()
$CmakeInstallArgs = @()

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ After installing the CUDA toolkit, you need to set variables to point CMake to t

For example
```powershell
> .github/scripts/Build-Windows.ps1 -Target x64 -ExtraCmakeFlags "-D LOCALVOCAL_WITH_CUDA=ON -D CUDA_TOOLKIT_ROOT_DIR='C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.4'"
.github/scripts/Build-Windows.ps1 -Target x64 -ExtraCmakeArgs '-D','LOCALVOCAL_WITH_CUDA=ON','-D',"CUDA_TOOLKIT_ROOT_DIR='C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.2'"
```

You will need to copy a few CUDA .dll files to the location of the plugin .dll for it to run. The required .dll files from CUDA (which are located in the `bin` folder of the CUDA toolkit installation directory) are:
Expand All @@ -104,4 +104,4 @@ You will need to copy a few CUDA .dll files to the location of the plugin .dll f
- `cublas64_NN.dll`
- `cublasLt64_NN.dll`

where `NN` is the CUDA version number. For example, if you have installed CUDA 11.4 then `NN` is likely `11`.
where `NN` is the CUDA major version number. For example, if you have installed CUDA 12.2 as in example above, then `NN` is `12`.

0 comments on commit c04565e

Please sign in to comment.