Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return set output #68

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Return set output #68

merged 3 commits into from
Oct 15, 2024

Conversation

NenadJovicic
Copy link
Contributor

Added back to have output of action, because exporting env variable won't work in cases like customer-apps where in one job, we have to calculate multiple deployment names, so env variable will be overriden

Not removing exportVariable because not sure does anyone use v2 of action, can't be found through github search. Looks like github search does not include .github folder in search

@crappylime
Copy link

Here you can find used versions https://github.com/search?q=org%3Alocal-ch+calculate-deployment-name%40&type=code some apps use v2

@NenadJovicic
Copy link
Contributor Author

@crappylime I didn't break anything in functionality
I tried same search, but for some reason, it didn't give me any results 😅
thanks
all are under our control, some of them are archived, or should be archived, and I didn't make any breaking changes
so we should be fine

Copy link

@crappylime crappylime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to mention in Readme which version is for what since I saw three different versions used in apps I guess for different reasons

@NenadJovicic
Copy link
Contributor Author

well, only projects on which Coa worked on have v2 used, because he updated it, and haven't thought about other use cases, and haven't updated any other project
v1 should be deprecated, because it uses old node version which won't be allowed soon by github actions
and in general, we should use latest v2
I will just update example in readme to show both options, env variable and output

@NenadJovicic NenadJovicic merged commit 35e88e7 into main Oct 15, 2024
2 checks passed
@NenadJovicic NenadJovicic deleted the return-set-output branch October 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants