Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#868aaqu6r Bug: Account creation forms #383

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sab-LC
Copy link
Collaborator

@sab-LC sab-LC commented Oct 22, 2024

Issue:

Description:
Whenever a user goes to create an institution or community account and inputs an invalid email, the form does not get submitted and no error message or alerts gets displayed to help the user know what went wrong.

Add an error message to the form when the contact email is invalid:
Please use a valid email

Solution:

  • Updated CreateCommunityForm, CreateInstitutionForm and CreateInstitutionNoRorForm forms to add custom email invalid message
  • Updated create-community, create-custom-institution and create-institution templates to include the error message div
  • Updated main.js to remove all the inputs for consistency

After:

  • Community Account:
Community-creation.mp4
  • Institution Account:
institute-creation.mp4
  • non-ROR Institution Account:
nonROR-institute-creation.mp4

@sab-LC sab-LC self-assigned this Oct 22, 2024
@arojas1
Copy link
Contributor

arojas1 commented Oct 22, 2024

@birbjam
Copy link
Contributor

birbjam commented Oct 24, 2024

@sab-LC is there a way to keep the data in the inputs so that the user can just correct what they had in there?

Copy link
Contributor

@arojas1 arojas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to Diana's comment, can you also add this for the Service Provider form as well just for consistency across all accounts?

Copy link
Contributor

@birbjam birbjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comments / questions in Slack before merge.

@sab-LC sab-LC changed the base branch from develop to subscriptions November 4, 2024 18:13
@sab-LC sab-LC changed the base branch from subscriptions to develop November 4, 2024 18:14
@sab-LC sab-LC force-pushed the 868aaqu6r-account-creation-forms branch from 64ec95b to 1ef83b2 Compare November 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants