-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin composer at version 1 until such time as the install works with c… #10
Conversation
Steve will have to rebuild the Docker image for this change to the Dockerfile to take effect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should solve our problem :)
@finnlewis @Adnan-cds @andybroomfield I think I have fixed this, but we will need to go through all the repos with CI configured and update the GitHub Actions file. The problem is that the Composer version in GitHub actions is version 2. To use Composer v1 we need to use the version installed in the Docker container. See the diff here: https://github.com/localgovdrupal/drupal-container/pull/10/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88 |
Looks like the Github actions build VM has switched to Composer 2 only 4 days ago. People have complained about it without any resolution. A potential solution mentioned in that issue is to use shivammathur/setup-php to install composer v1. I don't have preference for that solution over the changes for this PR given that both involves updating all our test workflow files :( But I thought I will mention it anyway in case you like it :) |
Thanks @Adnan-cds ! |
…omposer 2.