Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables redirect and redirect_404 by default #716

Merged
merged 3 commits into from
May 28, 2024

Conversation

markconroy
Copy link
Member

@markconroy markconroy commented May 23, 2024

Closes #624

===
Thanks to Big Blue Door for sponsoring my time to work on this.

@andybroomfield
Copy link
Contributor

I'd also make sure drupal/redirect is added to the profiles composer.json, it's currently in localgov_cores.

@markconroy
Copy link
Member Author

Thanks @andybroomfield. That's added now.

Copy link
Contributor

@andybroomfield andybroomfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markconroy we also need a corresponding one in localgov_core removing the redirect dependnacy from composer.json

@markconroy
Copy link
Member Author

@keelanfh
Copy link
Member

Patch should be added here: localgovdrupal/localgov_core#223 (comment)

@markconroy
Copy link
Member Author

Thanks @keelanfh - patch moved to the correct place now.

@finnlewis finnlewis merged commit dc756f3 into 3.x May 28, 2024
8 checks passed
@finnlewis finnlewis deleted the 624/enable-redirect-by-default branch May 28, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable redirect by default
4 participants