Compatibility with Workspaces #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Core patch for integration with workflows / content moderation. - Pathauto patch to prevent recalculation of aliases when publishing a space (order is not always good, and paths relying on paths, services parent for example, can be incorrect). - Redirect patch to allow it to be spaces aware, and avoid a sql error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Workspaces has issues with core, pathauto, and redirect that are experienced with LocalGov Drupal.
Core
https://www.drupal.org/project/drupal/issues/3179199
Most commonly the automatically created pathauto revision id will clash with a previous revision id of some content that is being published, causing (because of not checking entity type with revision id) an erroneous error that there is content in a non-default workflow state in the space. Very confusing.
How to test
Automated tests on the patch. Manual steps (I'd advise the last one) to reproduce on the issue.
Pathauto
https://www.drupal.org/project/pathauto/issues/3283769
Main problem experienced in manual testing with LGD was when something with a path pattern dependent on a parent (like services parent) was in a space that was published the paths were regenerated and the parent path would be /node/123 at the point of publishing, so the child ended up with node/123/child-title. With the patch paths are generated in the space, and not regenerated when the space is published.
How to test
Tediously create content in spaces with paths that depend on a parent till it goes wrong.
Redirect
https://www.drupal.org/project/redirect/issues/3431260
This one allows redirect to be somewhat workspaces aware. Notes on my earlier thoughts https://www.drupal.org/project/redirect/issues/3114103#comment-15714027
How to test (and problem)
Create content in a space, then change its title. It will generate a redirect, but this will fail with a fatal error as it tries to create a redirect.
How can we measure success?
Can use workspaces with LGD.
Have we considered potential risks?
Issues don't change data structure, so should be fine to apply. If they stop applying or a different approach is taken we had Workspaces working till then and will have to move to any other fix.