Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct styles and height of CKEditor 5 WYSIWYG #462

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Correct styles and height of CKEditor 5 WYSIWYG #462

merged 3 commits into from
Jul 3, 2023

Conversation

keelanfh
Copy link
Member

To support upgrade to Drupal 10, this covers:

  • adding a new CSS file for CKEditor 5 so styles appear in the WYSIWYG
  • declaring this file in the info.yml
  • some tweaks to take account of differences in the new CKEditor 5
  • adding a minimum height to the CKEditor boxes

With thanks to @justinepocock for advice in localgovdrupal/localgov_core#181 (comment).

@keelanfh keelanfh changed the title Correct styles and height of CKEditor 5 box in WYSIWYG Correct styles and height of CKEditor 5 WYSIWYG Jun 30, 2023
justinepocock
justinepocock approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@justinepocock justinepocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@keelanfh keelanfh merged commit ee11b0e into 1.x Jul 3, 2023
@keelanfh keelanfh mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinepocock justinepocock justinepocock approved these changes

@markconroy markconroy Awaiting requested review from markconroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keelanfh @justinepocock