Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEditor 5 wysiwyg profile changes #185

Merged
merged 3 commits into from
Jul 17, 2023
Merged

CKEditor 5 wysiwyg profile changes #185

merged 3 commits into from
Jul 17, 2023

Conversation

keelanfh
Copy link
Member

Since this is config, my understanding is that this should not affect existing installs.

We could be concerned about affecting existing installs but I think this is more logical for new ones.

@keelanfh
Copy link
Member Author

Closes #184

@finnlewis finnlewis self-assigned this Jul 3, 2023
@keelanfh keelanfh marked this pull request as draft July 5, 2023 07:57
@keelanfh
Copy link
Member Author

keelanfh commented Jul 5, 2023

I've updated this PR with a couple of other changes. This now includes, all for new installs only:

  • Changing class applied to Alert failure to alert-fail rather than alert-primary
  • To fix one of the things mentioned in Drupal 10 and CKEditor 5 issues/differences #181, I've removed the "code" and "code block" styles. We didn't have these styles in CKEditor 4, and I personally think they clutter up the editor.
  • I've re-added the default linkit profile here, which went missing in the move to CKEditor 5.
  • Removing bootstrap classes as mentioned in Do we still need bootstrap classes? localgov#582

@keelanfh keelanfh marked this pull request as ready for review July 5, 2023 08:57
@keelanfh keelanfh changed the title Change style applied to alert-fail CKEditor 5 wysiwyg profile changes Jul 5, 2023
@finnlewis finnlewis requested a review from kiwimind July 10, 2023 14:00
Copy link

@kiwimind kiwimind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comment #185 (comment), this all looks good.
I realise @finnlewis questioned the linkit addition, however if this is replacing functionality that went missing, that feels like another conversation.

@keelanfh keelanfh linked an issue Jul 10, 2023 that may be closed by this pull request
@keelanfh keelanfh merged commit 55e28b4 into 2.x Jul 17, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WYSIWYG style "Alert failure" creates alert-primary, not alert-fail
3 participants