Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strict types support #214

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: strict types support #214

merged 1 commit into from
May 7, 2024

Conversation

millnut
Copy link
Member

@millnut millnut commented May 4, 2024

Fix #210

Fixes strict type issues highlighted in the above issue.

ekes
ekes approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got to say I think strict type checking on string module names is all a bit much, but if that's what we gotta do.

Also forgot completely that method names weren't case sensitive!

@finnlewis finnlewis merged commit 04bb3a5 into 2.x May 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekes ekes ekes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strict types support
3 participants
@millnut @ekes @finnlewis