Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: additional strict type fixes #230

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: additional strict type fixes #230

merged 2 commits into from
Jun 18, 2024

Conversation

millnut
Copy link
Member

@millnut millnut commented Jun 17, 2024

Fixes the following errors, reported in localgovdrupal/localgov_project#153

 ------ ------------------------------------------------------------ 
  Line   modules/contrib/localgov_core/localgov_core.module          
 ------ ------------------------------------------------------------ 
  28     Only booleans are allowed in an if condition, mixed given.  
  31     Only booleans are allowed in an if condition, mixed given.  
 ------ ------------------------------------------------------------ 

 ------ -------------------------------------------------------------------- 
  Line   modules/contrib/localgov_core/src/Plugin/Block/PageHeaderBlock.php  
 ------ -------------------------------------------------------------------- 
  130    Only booleans are allowed in &&, mixed given on the right side.     
 ------ --------------------------------------------------------------------

@millnut millnut marked this pull request as draft June 17, 2024 18:49
@millnut millnut marked this pull request as ready for review June 17, 2024 19:07
markconroy
markconroy approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@markconroy markconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

===
Thanks to Big Blue Door for sponsoring my time to work on this.

@finnlewis finnlewis merged commit dc631ad into 2.x Jun 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markconroy markconroy markconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millnut @markconroy @finnlewis