Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed field formatter default for Enquiries email from text to email issue #340 #341

Conversation

bisd
Copy link
Member

@bisd bisd commented Feb 15, 2024

This is to complete PR localgovdrupal/localgov_base#523.
It relates to issue #340

@ekes
Copy link
Member

ekes commented Feb 20, 2024

Looks good, but I think we really only want the change to line 74. I suspect the next person coming along will put back { } for {} as that's how they export at the moment... or has this changed?

@bisd
Copy link
Member Author

bisd commented Feb 20, 2024

Thanks @ekes. VSCode is deleting the spaces within the braces on saving so I opened it in Sublime Text and reverted the spaces. The PR is still failing tests I am not sure why.

Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests are unrelated to this change.

Works now for setting the email to a link.

@ekes
Copy link
Member

ekes commented Feb 27, 2024

@bisd nice one thanks.

@finnlewis finnlewis merged commit 93b005f into 3.x Feb 27, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants