Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #354

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Update composer.json #354

merged 4 commits into from
Mar 11, 2024

Conversation

AWearring
Copy link
Contributor

Removed patch for PHP 8.2 compatibility for the 2.0.x branch: https://www.drupal.org/project/facets/issues/3336646 as this has been fixed in 2.0.7 of Drupal Facets Module: https://www.drupal.org/project/facets/releases/2.0.7

Removed patch for `PHP 8.2 compatibility for the 2.0.x branch: https://www.drupal.org/project/facets/issues/3336646` as this has been fixed in 2.0.7 of Drupal Facets Module: https://www.drupal.org/project/facets/releases/2.0.7
Copy link
Member

@millnut millnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AWearring it doesn't look like the formatting for this is correct

@AWearring
Copy link
Contributor Author

@millnut Should be sorted now - a case of "more haste and less speed"

@ekes
Copy link
Member

ekes commented Mar 11, 2024

Should we be sure that it updates then? So contstraining facets to ^2.0.7?

@millnut
Copy link
Member

millnut commented Mar 11, 2024

Should we be sure that it updates then? So contstraining facets to ^2.0.7?

Yep 2.0.7 is marked as recommended so I think we can increase the constraint to ^2.0.7 in composer.json

Increase the constraint for Facets module to ^2.0.7
@AWearring
Copy link
Contributor Author

Should we be sure that it updates then? So contstraining facets to ^2.0.7?

Yep 2.0.7 is marked as recommended so I think we can increase the constraint to ^2.0.7 in composer.json

Done

@AWearring AWearring requested a review from millnut March 11, 2024 10:31
Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @AWearring !

@finnlewis finnlewis merged commit 62df920 into 3.x Mar 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants