-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow module reinstall #392
base: 3.x
Are you sure you want to change the base?
Conversation
localgovdrupal/localgov#762 (comment) How much does directories keep on working when you uninstall it, but keep all the config in place? Is it possible someone is wanting to do this? Do we want to support it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to fully fix the issue described in #370 it also needs to add an enforced dependency to all the submodules in the modules
directory.
Further to my comment above, you are not prevented from uninstalling Directories if directory content exists, leaving phantom content which throws errors if you try to access it. We'll need to address this first localgovdrupal/localgov#762 |
Interesting! I think we'll need to test this a bit more. |
Discussing in Merge Tuesday, looking at the suggestion from @millnut on localgovdrupal/localgov#762 (comment)
We think we want to follow this, and write a validation to prevent uninstalling until the content has been deleted. |
Adding enforced dependencies to config files to allow reinstallation - see here: #370