Consider stacked h1 pattern for guides

[willguv]

The NHS guide page equivalent uses a single h1 for titles: page title above, overview title beneath

https://www.nhs.uk/conditions/acute-pancreatitis/causes/

The content group is enthusiastic about this change

We need to:

• consider as a default for new installs
• provide as an option to existing councils (as they may need to make theming changes to properly implement it)
• discuss whether this should be the default for step by step pages as well (replacing the "part of" panel)

[willguv]

Needs a bit more thought about how to turn on/ off

Challenge is how to roll out and not affect existing sites - not a block, so where does it live? Could be theme option

[ctorgalson]

@3mkay and I had a think about this, and I think we have a workable solution, assuming that the place to solve the problem is in the individual modules that consume the page header block, and not at the module that provides it.

In any case, we wanted to get some feedback before creating a PR, but the reasoning goes like this:

• we currently set the title with $event->setTitle(),

• setTitle() (like setLede()) will accept a render array,

• so localgov_guides could provide a hook_theme() implementation and a corresponding page-header.html.twig template,

• then, setTitle() in the event subscriber could do basically this:

  $event->setTitle([
    '#theme' => 'page_header',
    '#node' => $overview,
  ]);
  

To maintain backwards compatibility, the page-header.html.twig template provided by the module could basically be

{{ node.title }}

...but since we pass in the node, template overrides could use whatever node data (and markup) they need.

The main question I have is what we'd use to handle the differences between Guide Overviews and Guide pages:

1. logic in the event subscriber, preserving the existing behaviour for Guide Overview pages but permitting customization of Guide Page titles,
2. template suggestions from the module based on bundle,
3. just twig logic based on node.bundle,

(1) is probably simplest, (2) is probably most flexible, and (3) is probably most like what's already happening.

---

Does this sound like a workable solution? I'm not very deep into this module, so I could easily be overlooking something important.

[ctorgalson]

@willguv Any thoughts on this? We can put together a PR if it seems like a sensible approach to you.

[willguv]

Hi @ctorgalson sorry I hadn't replied to this - thanks for the nudge

Yes please go ahead, very kind of you!

Copying @stephen-cox

[willguv]

Hi @ctorgalson are you at Annertech by any chance? I think Haringey might have asked for this work already

[ctorgalson]

@willguv I am. Their request was what started us looking at this. I should have a chance to work on it soon.

[willguv]

Hi @ctorgalson hope all's well. Any news on this? Many thanks, Will

[andybroomfield]

See technical discussion and implementation for guides on #133 and possible more generic solution for opt in use on any content type on localgovdrupal/localgov_core#193

[willguv]

We're following NHS' lead by including both the title and lede in the h1

Agreed in the product group, @andybroomfield present

[willguv]

Hi @ctorgalson @markconroy, are you still working on this? Many thanks, Will

[willguv]

@markconroy would be good to pick this up and finish it if possible

[3mkay]

@willguv my understanding is that there was a change made upstream during our work which means we need to re-work what we’ve delivered on the HLBC site for it to apply.

[willguv]

Thanks @3mkay - is it a big job?

[andybroomfield]

Instructions in the 2.13 release notes
https://github.com/localgovdrupal/localgov_core/releases/tag/2.13.0

[ctorgalson]

I’m a bit confused. The release notes show a good way for any given LGD implementation to make use of the changes, but I’m unclear what we are proposing to do *here* (also, I think localgov_base might still need to print that `subtitle` variable, but I can’t check at the moment). On Wed, May 22, 2024 at 21:12, Andy Broomfield ***@***.***> wrote: Instructions in the 2.13 release notes https://github.com/localgovdrupal/localgov_core/releases/tag/2.13.0 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[markconroy]

Here's a PR to add the subtitle variable for localgov_base - localgovdrupal/localgov_base#561

[willguv]

@msayoung I vaguely remember writing this because a council raised accessibility and usability issues with the existing Guides pattern

There was a lot of enthusiasm for the change in the content group

Mark's done so enabling work to make this much easier to implement. Should we go ahead and make this change? If so, should it be a default or an option for councils?

Thanks

[willguv]

@markconroy should we go ahead and implement this change/ give councils an option to use it?

[markconroy]

Yes, I think it's okay to merge this one. We chatted about it a lot and gone around the implementation a few times.