-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stacked header subtitle as new page header variable #193
Conversation
Ref #192 This allows page subscribers to set a subtitle which will be stacked inside the h1.
Coming over from the PR 133 on I like this (though I would quibble pointlessly about that subtitle markup 😀). I have two additional suggestions:
The fact that what might be relatively simple things to handle in themes spawn issues like consider stacked h1 pattern for guides, and that (as you pointed out) |
Thanks for the suggestions @ctorgalson. I'll look into adding the entity, thats actully one thing to check over as it should be the case the page title block can be used with any entitiy and not just node, and in fact even stand alone controllers (we use it at BHCC to modify search to include the search terms). |
- Add subtitle test condition and amendment to test page header - Use xpath to get the header, as sometimes page title is found on page as it is the title tag. also, the adjustment of the template means the exact markup for the h1 breaks with newlines.
I'm marking this as ready for review, although this is just the adding of the subtitle. |
This looks good to me. |
It looks good to me too 👍 |
Fix #192
This allows page subscribers to set a subtitle which will be stacked inside the h1.