Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a non-cropped image to be uploaded through the WYSIWYG #239

Closed
msayoung opened this issue Sep 9, 2022 · 5 comments
Closed

Allow a non-cropped image to be uploaded through the WYSIWYG #239

msayoung opened this issue Sep 9, 2022 · 5 comments
Assignees

Comments

@msayoung
Copy link
Member

msayoung commented Sep 9, 2022

Trying to add the site logo to the footer. can't get an uncropped version

Image

@msayoung
Copy link
Member Author

msayoung commented Sep 9, 2022

In order to do this I propose that we

  1. Create a new crop type called "Freestyle" with no aspect ratio set
  2. Create a new image style using this crop type
  3. Enable this on the Image Media Type Form Display
  4. Create a new display mode for the Image Media Type
  5. On the display for the Image set the image field to use the Freestyle image style
  6. Allow the Freestyle display mode on the Ckeditor settings

Questions -

  1. would it be better to just show the original image without a crop?
  2. should there be a responsive image style in the mix?

@finnlewis
Copy link
Member

It would be good to have decent cropping set up.

So I think:

  1. no
  2. yes

@finnlewis
Copy link
Member

Note: presumably this will be added to localgov drupal media rather than microsites specifically.

@msayoung
Copy link
Member Author

I think we have some clever override for our microsite's WSYWYG actually, so while it's available in LGD Core the WYSWYG won't update automatically

localgovdrupal/localgov_core#145
#262

@msayoung
Copy link
Member Author

It sounds like there is a request for this in the wild, so we should get it in to core too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done Sprint 14
Development

No branches or pull requests

3 participants