Add a freestyle crop, image styles and responsive image style, image… #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msayoung
changed the title
markconroy
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Checked on microsites and this does what it says on the tin, however I'm wary of the responsive freestyle image style. Just because someone is on a large screen does not mean they will want each freestyle image to be 1200px wide. For example, embedding a headshot of a councillor. you might just want it to be 300px wide.
Is this a concern? If not, I'm happy to approve.
|
It's true - Do you have any thoughts on how we deal with this @markconroy ? |
|
From our discussion on the Merge Monday call, I think we're good to go with this @msayoung We noted we would follow up on another issue with @markconroy to explore how to give content designers the info they need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… view mode