Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks for $is_syncing #198

Merged
merged 1 commit into from
Sep 5, 2024
Merged

checks for $is_syncing #198

merged 1 commit into from
Sep 5, 2024

Conversation

markconroy
Copy link
Member

Closes #197

@markconroy markconroy mentioned this pull request Aug 26, 2024
Open
20 tasks
ekes
ekes approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All config changes, so if we're importing config these can/should be skipped. @rupertj do you agree?

@finnlewis
Copy link
Member

@ekes wanted to leave this for @rupertj to double check and confirm.

@ekes ekes requested a review from rupertj September 3, 2024 09:43
@rupertj
Copy link
Member

rupertj commented Sep 3, 2024

Yeah, that's all config in those functions after the early return, so this looks sensible to me.

@rupertj rupertj merged commit 77cbdb3 into 1.x Sep 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupertj rupertj rupertj approved these changes

@ekes ekes ekes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hook_install should not be making config changes when importing config ($is_syncing == TRUE)
4 participants
@markconroy @finnlewis @rupertj @ekes