rework sample for dev hub #1
Conversation
There was a problem hiding this comment.
Nice work 🎉
From my side, everything looks fine (except a small typo) 👍
Please also add "topics" to the project description so it can be found easier 🙏 (guidelines are in notion).
Great to have the CI pipeline, with a smoke test as well 🙂
We might want to add the keepalive-workflow so the workflow will not go stale.
Also tagging @HarshCasper for the final approval 🙏
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: diagnose.json.gz | ||
| path: ./diagnose.json.gz |
There was a problem hiding this comment.
we haven't really decided yet on how we want to prevent the workflows from getting stale.
I started adding the keepalive-workflow action for the workflows where we test cloudpods, but I don't think we will be able those workflows to all samples in the first iteration.
Therefore, it might be a good idea to add the action in this main.yml for the specific sample? WDYT @HarshCasper?
This PR adapts the sample to be ready for the developer hub, according to our standards. Work includes