Backend update #13
Merged
Backend update #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Nice set of changes @Pive01 🚀 . My main comment would be around the REST API design - if it's not too much effort, maybe we could look into restructuring them a bit?
Also, I realized that the backend server may become more complex over time. I think it's still ok in terms of complexity now, but we currently have mainly Python knowledge in the team, and the question will be how much of a rabbit hole it may still end up becoming.. :) Let's maybe discuss separately what the longer-term strategy is, and whether we want to continue going with Golang, or use Python instead (which, afaik should also work for the backend component..?). 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content