Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env variables addon #2

Merged
merged 12 commits into from
Oct 19, 2022
Merged

Env variables addon #2

merged 12 commits into from
Oct 19, 2022

Conversation

Pive01
Copy link
Collaborator

@Pive01 Pive01 commented Sep 27, 2022

Added option to configure environment variables

Screenshot from 2022-10-05 12-14-46
Screenshot from 2022-10-05 12-14-49

Screenshot from 2022-10-05 12-15-11

Other changes :

  • downgraded to a more stable version of some packages
  • added .env file so the UI Is correctly displayed
  • instead of checking if health is live to know if LocalStack is running now it checks directly if localstack/localstack is running inside a container
  • Log Output now shows the output of the container
  • Divided main view into tabs

Maybe on the next PR we can start making it look more user-friendly

@whummer
Copy link
Member

whummer commented Sep 27, 2022

Looks awesome - great to see the direction this is going @Pive01 ! 🚀 Would be great to get an additional pair of eyes from @lukqw and/or @pandomic (once the PR is ready to review..). 👍

@Pive01
Copy link
Collaborator Author

Pive01 commented Oct 5, 2022

Looks awesome - great to see the direction this is going @Pive01 ! rocket Would be great to get an additional pair of eyes from @lukqw and/or @pandomic (once the PR is ready to review..). +1

I think it's time to review....WDYT @whummer ? Also would be nice to change the repository from pive01/... to localstack/.. as soon I got the permissions...or you can clone it and do it yourself 👍

@whummer
Copy link
Member

whummer commented Oct 5, 2022

That's great @Pive01 ! We'll take a look shortly - currently the team is still busy resolving a high-priority incident, but we should have some capacity in a couple of days.. :) 👍

Can you please maybe add a short description (ideally in the README) on how your changes can be tested locally? Thanks!

/cc @pandomic @lukqw

@Pive01
Copy link
Collaborator Author

Pive01 commented Oct 5, 2022

That's great @Pive01 ! We'll take a look shortly - currently the team is still busy resolving a high-priority incident, but we should have some capacity in a couple of days.. :) +1

Can you please maybe add a short description (ideally in the README) on how your changes can be tested locally? Thanks!

/cc @pandomic @lukqw

OK, I've added a small description in the Readme with what to do and some commands 👍

@whummer whummer requested a review from lukqw October 18, 2022 09:17
Copy link
Member

@lukqw lukqw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - Great work @Pive01! Can't wait to see this in action.

Only added a small nitpick since I found a typo.

@Pive01 Pive01 merged commit 9ba555a into main Oct 19, 2022
@HarshCasper HarshCasper deleted the env-variables-addon branch October 19, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants