-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Env variables addon #2
Conversation
I think it's time to review....WDYT @whummer ? Also would be nice to change the repository from pive01/... to localstack/.. as soon I got the permissions...or you can clone it and do it yourself 👍 |
That's great @Pive01 ! We'll take a look shortly - currently the team is still busy resolving a high-priority incident, but we should have some capacity in a couple of days.. :) 👍 Can you please maybe add a short description (ideally in the README) on how your changes can be tested locally? Thanks! |
OK, I've added a small description in the Readme with what to do and some commands 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - Great work @Pive01! Can't wait to see this in action.
Only added a small nitpick since I found a typo.
Added option to configure environment variables
Other changes :
Maybe on the next PR we can start making it look more user-friendly