fix(Invoke): Fixed Windows Issue by shipping pre-built binaries for platforms #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
reviewed
Jan 4, 2024
There was a problem hiding this comment.
LGTM overall, kudos for tackling this @Pive01 ! 🚀 Nice approach with using the CLI binaries directly, rather than spawning the separate container.
My only concern is around checking in the CLI binaries to this repo - they are fairly large, and it would be preferable to not have them in the repo imo (as we'll likely need to update them frequently over time). Could we download them from the Github releases page, or alternatively put them into an S3 bucket and download them when building the image? (i.e., in Dockerfile)
Co-authored-by: Waldemar Hummer <waldemar.hummer@gmail.com>
Yes, I've added a little script that download and extract them when you build the extension 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves away from the logic we used until now: spawning a container and invoking the cli within the container. Now we ship all the binaries with the extension itself and invoke the correct ones based on the host OS/architecture. This is made to circumvent an issue we currently have on Windows machines where the path for the LOCALSTACK_VOLUME_DIR env variable was being mixed with Windows and Unix pathing.
/cc @alexrashed
Closes #52