-
Notifications
You must be signed in to change notification settings - Fork 19
Image resizer hot reload [#237] #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Image resizer hot reload [#237] #303
Conversation
Add - Testing the application
Removed the testing section for the application
|
Request for review from @remotesynth, @quetzalliwrites, @HarshCasper. Has been held up since 3 weeks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! The content is helpful, but the formatting feels a bit uneven and the section reads a bit bare. I’d suggest tightening up the markdown structure and expanding with a short “why/use case” blurb or example to give it more context before merging.
|
Sure, I'll work on those changes before finalizing the PR |
Added a new section on use cases for image resizing and updated the steps for clarity. Enhanced the document structure with additional headers and improved descriptions.
|
@blkgrlcto please do lmk if the updated markdown file looks fine |
Hi @AdityaSriram09. Appreciate the submission but there were a number of issues with the frontmatter that were preventing a build. The leadimage doesn't seem to exist which is still preventing a build, which I'll be unable to address today unfortunately. |
|
Hey @AdityaSriram09 please refer to the sample app readme. Upon a second look, this tutorial is missing references to SNS, SES for error notifications and email alerts, and SSM Parameter Store for configuration management. |
Fix for #237
@blkgrlcto please review it