-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SFN] Support for JsonPath Regexes #9942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MEPalma
added
the
semver: patch
Non-breaking changes which can be included in patch releases
label
Dec 26, 2023
1 task
I would love to see this merged :) |
dominikschubert
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I'd be curious to see at some point what subset of jsonpath stepfunctions on AWS supports, but I guess for now just depending on jsonpath_ng and its support should be fine for most use cases. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the SFN v2 provider incorrectly parses json path strings especially when filtering options. Furthermore, the non extended version of
jsonpath_ng
parser is used. The PR simplified the parsing of json path definitions and delegates them all as a complete string tojsonpath_ng
. The PR also resolves some issue with returning single objects or list of objects in some json path accesses.However, currently, the
jsonpath_ng
is not always able to adhere to spec h2non/jsonpath-ng#8. This issue should be followed in the future, and the tests added in this PR enabled for filtering json path definitions. Addresses and stales: #9937Changes
jsonpath_ng
ext
parser